fix(numbers): correctly determine malformed decimals #1042
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928
Problem:
The current code was primarily designed for numbers like
3,400.00
, where the r-stripped value (3,400.
) matches the expectedproper
(3,400
) +.
(3,400.
) format. It doesn't work for numbers like3,400.60
since3,400.6
(the value after r-stripping) is incorrectly perceived as not equal to the expected format, which is theproper
(3,400.6
) +.
(3,400.6.
), thereby leading to its erroneous detection as improperly formatted.Solution:
Added a more robust method for stripping trailing zeros, specifically targeting only those zeros that appear after the last non-zero digit following the decimal symbol.