diff --git a/setup.py b/setup.py index 66b9125f99b..c8fc91a583b 100644 --- a/setup.py +++ b/setup.py @@ -16,10 +16,11 @@ import sys import warnings from collections.abc import Iterator -from typing import Any, TYPE_CHECKING +from typing import TYPE_CHECKING, Any from setuptools import Extension, setup from setuptools.command.build_ext import build_ext + if TYPE_CHECKING: from setuptools import _BuildInfo diff --git a/src/Tk/tkImaging.c b/src/Tk/tkImaging.c index 3e35f885f61..834634bd7fa 100644 --- a/src/Tk/tkImaging.c +++ b/src/Tk/tkImaging.c @@ -124,10 +124,8 @@ PyImagingPhotoPut( if (im->mode == IMAGING_MODE_1 || im->mode == IMAGING_MODE_L) { block.pixelSize = 1; block.offset[0] = block.offset[1] = block.offset[2] = block.offset[3] = 0; - } else if ( - im->mode == IMAGING_MODE_RGB || im->mode == IMAGING_MODE_RGBA || - im->mode == IMAGING_MODE_RGBX || im->mode == IMAGING_MODE_RGBa - ) { + } else if (im->mode == IMAGING_MODE_RGB || im->mode == IMAGING_MODE_RGBA || + im->mode == IMAGING_MODE_RGBX || im->mode == IMAGING_MODE_RGBa) { block.pixelSize = 4; block.offset[0] = 0; block.offset[1] = 1; diff --git a/src/_imaging.c b/src/_imaging.c index 9dcf9de7b27..ce65ab7ae2e 100644 --- a/src/_imaging.c +++ b/src/_imaging.c @@ -1720,7 +1720,9 @@ _quantize(ImagingObject *self, PyObject *args) { if (!self->image->xsize || !self->image->ysize) { /* no content; return an empty image */ - return PyImagingNew(ImagingNew(IMAGING_MODE_P, self->image->xsize, self->image->ysize)); + return PyImagingNew( + ImagingNew(IMAGING_MODE_P, self->image->xsize, self->image->ysize) + ); } return PyImagingNew(ImagingQuantize(self->image, colours, method, kmeans)); @@ -2004,7 +2006,8 @@ _reduce(ImagingObject *self, PyObject *args) { static int isRGB(const ModeID mode) { - return mode == IMAGING_MODE_RGB || mode == IMAGING_MODE_RGBA || mode == IMAGING_MODE_RGBX; + return mode == IMAGING_MODE_RGB || mode == IMAGING_MODE_RGBA || + mode == IMAGING_MODE_RGBX; } static PyObject * diff --git a/src/_imagingcms.c b/src/_imagingcms.c index 0cd7c21a9f7..9137c12ee84 100644 --- a/src/_imagingcms.c +++ b/src/_imagingcms.c @@ -212,7 +212,7 @@ cms_transform_dealloc(CmsTransformObject *self) { /* internal functions */ static cmsUInt32Number -findLCMStype(const char * const mode_name) { +findLCMStype(const char *const mode_name) { const ModeID mode = findModeID(mode_name); switch (mode) { case IMAGING_MODE_RGB: @@ -230,7 +230,9 @@ findLCMStype(const char * const mode_name) { return TYPE_YCbCr_8; case IMAGING_MODE_LAB: // LabX equivalent like ALab, but not reversed -- no #define in lcms2 - return (COLORSPACE_SH(PT_LabV2) | CHANNELS_SH(3) | BYTES_SH(1) | EXTRA_SH(1)); + return ( + COLORSPACE_SH(PT_LabV2) | CHANNELS_SH(3) | BYTES_SH(1) | EXTRA_SH(1) + ); default: // This function only accepts a subset of the imaging modes Pillow has. break; diff --git a/src/_imagingft.c b/src/_imagingft.c index eb519270d3c..b41efe25fe4 100644 --- a/src/_imagingft.c +++ b/src/_imagingft.c @@ -769,7 +769,14 @@ font_getsize(FontObject *self, PyObject *args) { /* calculate size and bearing for a given string */ if (!PyArg_ParseTuple( - args, "O|zzOzz:getsize", &string, &mode_name, &dir, &features, &lang, &anchor + args, + "O|zzOzz:getsize", + &string, + &mode_name, + &dir, + &features, + &lang, + &anchor )) { return NULL; } diff --git a/src/decode.c b/src/decode.c index a39babe5311..85cd25bd52b 100644 --- a/src/decode.c +++ b/src/decode.c @@ -293,7 +293,9 @@ static PyTypeObject ImagingDecoderType = { /* -------------------------------------------------------------------- */ int -get_unpacker(ImagingDecoderObject *decoder, const ModeID mode, const RawModeID rawmode) { +get_unpacker( + ImagingDecoderObject *decoder, const ModeID mode, const RawModeID rawmode +) { int bits; ImagingShuffler unpack; @@ -324,7 +326,9 @@ PyImaging_BitDecoderNew(PyObject *self, PyObject *args) { int fill = 0; int sign = 0; int ystep = 1; - if (!PyArg_ParseTuple(args, "s|iiiii", &mode_name, &bits, &pad, &fill, &sign, &ystep)) { + if (!PyArg_ParseTuple( + args, "s|iiiii", &mode_name, &bits, &pad, &fill, &sign, &ystep + )) { return NULL; } @@ -435,7 +439,9 @@ PyImaging_GifDecoderNew(PyObject *self, PyObject *args) { int bits = 8; int interlace = 0; int transparency = -1; - if (!PyArg_ParseTuple(args, "s|iii", &mode_name, &bits, &interlace, &transparency)) { + if (!PyArg_ParseTuple( + args, "s|iii", &mode_name, &bits, &interlace, &transparency + )) { return NULL; } @@ -508,7 +514,9 @@ PyImaging_LibTiffDecoderNew(PyObject *self, PyObject *args) { int fp; uint32_t ifdoffset; - if (!PyArg_ParseTuple(args, "sssiI", &mode_name, &rawmode_name, &compname, &fp, &ifdoffset)) { + if (!PyArg_ParseTuple( + args, "sssiI", &mode_name, &rawmode_name, &compname, &fp, &ifdoffset + )) { return NULL; } @@ -850,12 +858,14 @@ PyImaging_JpegDecoderNew(PyObject *self, PyObject *args) { ImagingDecoderObject *decoder; char *mode_name; - char *rawmode_name; /* what we want from the decoder */ + char *rawmode_name; /* what we want from the decoder */ char *jpegmode_name; /* what's in the file */ int scale = 1; int draft = 0; - if (!PyArg_ParseTuple(args, "ssz|ii", &mode_name, &rawmode_name, &jpegmode_name, &scale, &draft)) { + if (!PyArg_ParseTuple( + args, "ssz|ii", &mode_name, &rawmode_name, &jpegmode_name, &scale, &draft + )) { return NULL; } diff --git a/src/encode.c b/src/encode.c index 016c4a52dd6..3f4f4319b28 100644 --- a/src/encode.c +++ b/src/encode.c @@ -367,7 +367,12 @@ get_packer(ImagingEncoderObject *encoder, const ModeID mode, const RawModeID raw pack = ImagingFindPacker(mode, rawmode, &bits); if (!pack) { Py_DECREF(encoder); - PyErr_Format(PyExc_ValueError, "No packer found from %s to %s", getModeData(mode)->name, getRawModeData(rawmode)->name); + PyErr_Format( + PyExc_ValueError, + "No packer found from %s to %s", + getModeData(mode)->name, + getRawModeData(rawmode)->name + ); return -1; } @@ -407,7 +412,9 @@ PyImaging_GifEncoderNew(PyObject *self, PyObject *args) { char *rawmode_name; Py_ssize_t bits = 8; Py_ssize_t interlace = 0; - if (!PyArg_ParseTuple(args, "ss|nn", &mode_name, &rawmode_name, &bits, &interlace)) { + if (!PyArg_ParseTuple( + args, "ss|nn", &mode_name, &rawmode_name, &bits, &interlace + )) { return NULL; } @@ -1152,7 +1159,7 @@ PyImaging_JpegEncoderNew(PyObject *self, PyObject *args) { } const ModeID mode = findModeID(mode_name); - RawModeID rawmode = findRawModeID(rawmode_name); + RawModeID rawmode = findRawModeID(rawmode_name); // libjpeg-turbo supports different output formats. // We are choosing Pillow's native format (3 color bytes + 1 padding) diff --git a/src/libImaging/Access.c b/src/libImaging/Access.c index 9d207639801..a4829ebb4bd 100644 --- a/src/libImaging/Access.c +++ b/src/libImaging/Access.c @@ -11,7 +11,6 @@ #include "Imaging.h" - /* fetch individual pixel */ static void @@ -102,7 +101,6 @@ get_pixel_32B(Imaging im, int x, int y, void *color) { #endif } - /* store individual pixel */ static void @@ -153,7 +151,6 @@ put_pixel_32(Imaging im, int x, int y, const void *color) { memcpy(&im->image32[y][x], color, sizeof(INT32)); } - static struct ImagingAccessInstance accessors[] = { {IMAGING_MODE_1, get_pixel_8, put_pixel_8}, {IMAGING_MODE_L, get_pixel_8, put_pixel_8}, diff --git a/src/libImaging/Chops.c b/src/libImaging/Chops.c index ed29a8c43ae..331f2dfe64c 100644 --- a/src/libImaging/Chops.c +++ b/src/libImaging/Chops.c @@ -42,21 +42,21 @@ } \ return imOut; -#define CHOP2(operation, mode) \ - int x, y; \ - Imaging imOut; \ - imOut = create(imIn1, imIn2, mode); \ - if (!imOut) { \ - return NULL; \ - } \ - for (y = 0; y < imOut->ysize; y++) { \ - UINT8 *out = (UINT8 *)imOut->image[y]; \ - UINT8 *in1 = (UINT8 *)imIn1->image[y]; \ - UINT8 *in2 = (UINT8 *)imIn2->image[y]; \ - for (x = 0; x < imOut->linesize; x++) { \ - out[x] = operation; \ - } \ - } \ +#define CHOP2(operation, mode) \ + int x, y; \ + Imaging imOut; \ + imOut = create(imIn1, imIn2, mode); \ + if (!imOut) { \ + return NULL; \ + } \ + for (y = 0; y < imOut->ysize; y++) { \ + UINT8 *out = (UINT8 *)imOut->image[y]; \ + UINT8 *in1 = (UINT8 *)imIn1->image[y]; \ + UINT8 *in2 = (UINT8 *)imIn2->image[y]; \ + for (x = 0; x < imOut->linesize; x++) { \ + out[x] = operation; \ + } \ + } \ return imOut; static Imaging diff --git a/src/libImaging/Convert.c b/src/libImaging/Convert.c index b62c1652123..b8ad5560337 100644 --- a/src/libImaging/Convert.c +++ b/src/libImaging/Convert.c @@ -1624,9 +1624,7 @@ static struct { }; static Imaging -convert( - Imaging imOut, Imaging imIn, ModeID mode, ImagingPalette palette, int dither -) { +convert(Imaging imOut, Imaging imIn, ModeID mode, ImagingPalette palette, int dither) { ImagingSectionCookie cookie; ImagingShuffler convert; @@ -1677,7 +1675,11 @@ convert( #else static char buf[100]; snprintf( - buf, 100, "conversion from %.10s to %.10s not supported", getModeData(imIn->mode)->name, getModeData(mode)->name + buf, + 100, + "conversion from %.10s to %.10s not supported", + getModeData(imIn->mode)->name, + getModeData(mode)->name ); return (Imaging)ImagingError_ValueError(buf); #endif @@ -1722,25 +1724,22 @@ ImagingConvertTransparent(Imaging imIn, const ModeID mode, int r, int g, int b) return (Imaging)ImagingError_ModeError(); } - if (imIn->mode == IMAGING_MODE_RGB && (mode == IMAGING_MODE_RGBA || mode == IMAGING_MODE_RGBa)) { + if (imIn->mode == IMAGING_MODE_RGB && + (mode == IMAGING_MODE_RGBA || mode == IMAGING_MODE_RGBa)) { convert = rgb2rgba; if (mode == IMAGING_MODE_RGBa) { premultiplied = 1; } - } else if (imIn->mode == IMAGING_MODE_RGB && (mode == IMAGING_MODE_LA || mode == IMAGING_MODE_La)) { + } else if (imIn->mode == IMAGING_MODE_RGB && + (mode == IMAGING_MODE_LA || mode == IMAGING_MODE_La)) { convert = rgb2la; source_transparency = 1; if (mode == IMAGING_MODE_La) { premultiplied = 1; } - } else if ((imIn->mode == IMAGING_MODE_1 || - imIn->mode == IMAGING_MODE_I || - imIn->mode == IMAGING_MODE_I_16 || - imIn->mode == IMAGING_MODE_L - ) && ( - mode == IMAGING_MODE_RGBA || - mode == IMAGING_MODE_LA - )) { + } else if ((imIn->mode == IMAGING_MODE_1 || imIn->mode == IMAGING_MODE_I || + imIn->mode == IMAGING_MODE_I_16 || imIn->mode == IMAGING_MODE_L) && + (mode == IMAGING_MODE_RGBA || mode == IMAGING_MODE_LA)) { if (imIn->mode == IMAGING_MODE_1) { convert = bit2rgb; } else if (imIn->mode == IMAGING_MODE_I) { diff --git a/src/libImaging/Fill.c b/src/libImaging/Fill.c index 783110bfe4e..a8dae87f4c4 100644 --- a/src/libImaging/Fill.c +++ b/src/libImaging/Fill.c @@ -72,10 +72,8 @@ ImagingFillLinearGradient(const ModeID mode) { Imaging im; int y; - if (mode != IMAGING_MODE_1 && mode != IMAGING_MODE_F && - mode != IMAGING_MODE_I && mode != IMAGING_MODE_L && - mode != IMAGING_MODE_P - ) { + if (mode != IMAGING_MODE_1 && mode != IMAGING_MODE_F && mode != IMAGING_MODE_I && + mode != IMAGING_MODE_L && mode != IMAGING_MODE_P) { return (Imaging)ImagingError_ModeError(); } @@ -110,10 +108,8 @@ ImagingFillRadialGradient(const ModeID mode) { int x, y; int d; - if (mode != IMAGING_MODE_1 && mode != IMAGING_MODE_F && - mode != IMAGING_MODE_I && mode != IMAGING_MODE_L && - mode != IMAGING_MODE_P - ) { + if (mode != IMAGING_MODE_1 && mode != IMAGING_MODE_F && mode != IMAGING_MODE_I && + mode != IMAGING_MODE_L && mode != IMAGING_MODE_P) { return (Imaging)ImagingError_ModeError(); } diff --git a/src/libImaging/GetBBox.c b/src/libImaging/GetBBox.c index 3719a9f1576..f94cf2a0e5f 100644 --- a/src/libImaging/GetBBox.c +++ b/src/libImaging/GetBBox.c @@ -89,11 +89,10 @@ ImagingGetBBox(Imaging im, int bbox[4], int alpha_only) { INT32 mask = 0xffffffff; if (im->bands == 3) { ((UINT8 *)&mask)[3] = 0; - } else if (alpha_only && ( - im->mode == IMAGING_MODE_RGBa || im->mode == IMAGING_MODE_RGBA || - im->mode == IMAGING_MODE_La || im->mode == IMAGING_MODE_LA || - im->mode == IMAGING_MODE_PA - )) { + } else if (alpha_only && + (im->mode == IMAGING_MODE_RGBa || im->mode == IMAGING_MODE_RGBA || + im->mode == IMAGING_MODE_La || im->mode == IMAGING_MODE_LA || + im->mode == IMAGING_MODE_PA)) { #ifdef WORDS_BIGENDIAN mask = 0x000000ff; #else diff --git a/src/libImaging/Imaging.h b/src/libImaging/Imaging.h index b9e38a75734..2fcb4a7a6e5 100644 --- a/src/libImaging/Imaging.h +++ b/src/libImaging/Imaging.h @@ -77,11 +77,12 @@ typedef struct { struct ImagingMemoryInstance { /* Format */ - ModeID mode; /* Band names ("1", "L", "P", "RGB", "RGBA", "CMYK", "YCbCr", "BGR;xy") */ - int type; /* Data type (IMAGING_TYPE_*) */ - int depth; /* Depth (ignored in this version) */ - int bands; /* Number of bands (1, 2, 3, or 4) */ - int xsize; /* Image dimension. */ + ModeID + mode; /* Band names ("1", "L", "P", "RGB", "RGBA", "CMYK", "YCbCr", "BGR;xy") */ + int type; /* Data type (IMAGING_TYPE_*) */ + int depth; /* Depth (ignored in this version) */ + int bands; /* Number of bands (1, 2, 3, or 4) */ + int xsize; /* Image dimension. */ int ysize; /* Colour palette (for "P" images only) */ @@ -128,7 +129,7 @@ struct ImagingAccessInstance { struct ImagingHistogramInstance { /* Format */ ModeID mode; /* ModeID of corresponding source image */ - int bands; /* Number of bands (1, 3, or 4) */ + int bands; /* Number of bands (1, 3, or 4) */ /* Data */ long *histogram; /* Histogram (bands*256 longs) */ diff --git a/src/libImaging/JpegDecode.c b/src/libImaging/JpegDecode.c index f5642a9a6f2..ae3274456d3 100644 --- a/src/libImaging/JpegDecode.c +++ b/src/libImaging/JpegDecode.c @@ -206,9 +206,8 @@ ImagingJpegDecode(Imaging im, ImagingCodecState state, UINT8 *buf, Py_ssize_t by context->cinfo.out_color_space = JCS_EXT_RGBX; } #endif - else if ( - context->rawmode == IMAGING_RAWMODE_CMYK || - context->rawmode == IMAGING_RAWMODE_CMYK_I) { + else if (context->rawmode == IMAGING_RAWMODE_CMYK || + context->rawmode == IMAGING_RAWMODE_CMYK_I) { context->cinfo.out_color_space = JCS_CMYK; } else if (context->rawmode == IMAGING_RAWMODE_YCbCr) { context->cinfo.out_color_space = JCS_YCbCr; diff --git a/src/libImaging/Matrix.c b/src/libImaging/Matrix.c index 6bc9fbc1de2..d28e04edfaa 100644 --- a/src/libImaging/Matrix.c +++ b/src/libImaging/Matrix.c @@ -46,11 +46,8 @@ ImagingConvertMatrix(Imaging im, const ModeID mode, float m[]) { } } ImagingSectionLeave(&cookie); - } else if ( - mode == IMAGING_MODE_HSV || - mode == IMAGING_MODE_LAB || - mode == IMAGING_MODE_RGB - ) { + } else if (mode == IMAGING_MODE_HSV || mode == IMAGING_MODE_LAB || + mode == IMAGING_MODE_RGB) { imOut = ImagingNewDirty(mode, im->xsize, im->ysize); if (!imOut) { return NULL; diff --git a/src/libImaging/Mode.c b/src/libImaging/Mode.c index 96fde31979d..8222c585b68 100644 --- a/src/libImaging/Mode.c +++ b/src/libImaging/Mode.c @@ -6,40 +6,28 @@ #include #endif - const ModeData MODES[] = { [IMAGING_MODE_UNKNOWN] = {""}, - [IMAGING_MODE_1] = {"1"}, - [IMAGING_MODE_CMYK] = {"CMYK"}, - [IMAGING_MODE_F] = {"F"}, - [IMAGING_MODE_HSV] = {"HSV"}, - [IMAGING_MODE_I] = {"I"}, - [IMAGING_MODE_L] = {"L"}, - [IMAGING_MODE_LA] = {"LA"}, - [IMAGING_MODE_LAB] = {"LAB"}, - [IMAGING_MODE_La] = {"La"}, - [IMAGING_MODE_P] = {"P"}, - [IMAGING_MODE_PA] = {"PA"}, - [IMAGING_MODE_RGB] = {"RGB"}, - [IMAGING_MODE_RGBA] = {"RGBA"}, - [IMAGING_MODE_RGBX] = {"RGBX"}, - [IMAGING_MODE_RGBa] = {"RGBa"}, - [IMAGING_MODE_YCbCr] = {"YCbCr"}, + [IMAGING_MODE_1] = {"1"}, [IMAGING_MODE_CMYK] = {"CMYK"}, + [IMAGING_MODE_F] = {"F"}, [IMAGING_MODE_HSV] = {"HSV"}, + [IMAGING_MODE_I] = {"I"}, [IMAGING_MODE_L] = {"L"}, + [IMAGING_MODE_LA] = {"LA"}, [IMAGING_MODE_LAB] = {"LAB"}, + [IMAGING_MODE_La] = {"La"}, [IMAGING_MODE_P] = {"P"}, + [IMAGING_MODE_PA] = {"PA"}, [IMAGING_MODE_RGB] = {"RGB"}, + [IMAGING_MODE_RGBA] = {"RGBA"}, [IMAGING_MODE_RGBX] = {"RGBX"}, + [IMAGING_MODE_RGBa] = {"RGBa"}, [IMAGING_MODE_YCbCr] = {"YCbCr"}, - [IMAGING_MODE_BGR_15] = {"BGR;15"}, - [IMAGING_MODE_BGR_16] = {"BGR;16"}, + [IMAGING_MODE_BGR_15] = {"BGR;15"}, [IMAGING_MODE_BGR_16] = {"BGR;16"}, [IMAGING_MODE_BGR_24] = {"BGR;24"}, - [IMAGING_MODE_I_16] = {"I;16"}, - [IMAGING_MODE_I_16L] = {"I;16L"}, - [IMAGING_MODE_I_16B] = {"I;16B"}, - [IMAGING_MODE_I_16N] = {"I;16N"}, - [IMAGING_MODE_I_32L] = {"I;32L"}, - [IMAGING_MODE_I_32B] = {"I;32B"}, + [IMAGING_MODE_I_16] = {"I;16"}, [IMAGING_MODE_I_16L] = {"I;16L"}, + [IMAGING_MODE_I_16B] = {"I;16B"}, [IMAGING_MODE_I_16N] = {"I;16N"}, + [IMAGING_MODE_I_32L] = {"I;32L"}, [IMAGING_MODE_I_32B] = {"I;32B"}, }; -const ModeID findModeID(const char * const name) { +const ModeID +findModeID(const char *const name) { if (name == NULL) { return IMAGING_MODE_UNKNOWN; } @@ -49,21 +37,21 @@ const ModeID findModeID(const char * const name) { fprintf(stderr, "Mode ID %zu is not defined.\n", (size_t)i); } else #endif - if (strcmp(MODES[i].name, name) == 0) { + if (strcmp(MODES[i].name, name) == 0) { return (ModeID)i; } } return IMAGING_MODE_UNKNOWN; } -const ModeData * const getModeData(const ModeID id) { +const ModeData *const +getModeData(const ModeID id) { if (id < 0 || id > sizeof(MODES) / sizeof(*MODES)) { return &MODES[IMAGING_MODE_UNKNOWN]; } return &MODES[id]; } - const RawModeData RAWMODES[] = { [IMAGING_RAWMODE_UNKNOWN] = {""}, @@ -243,7 +231,8 @@ const RawModeData RAWMODES[] = { [IMAGING_RAWMODE_aRGB] = {"aRGB"}, }; -const RawModeID findRawModeID(const char * const name) { +const RawModeID +findRawModeID(const char *const name) { if (name == NULL) { return IMAGING_RAWMODE_UNKNOWN; } @@ -253,24 +242,23 @@ const RawModeID findRawModeID(const char * const name) { fprintf(stderr, "Rawmode ID %zu is not defined.\n", (size_t)i); } else #endif - if (strcmp(RAWMODES[i].name, name) == 0) { + if (strcmp(RAWMODES[i].name, name) == 0) { return (RawModeID)i; } } return IMAGING_RAWMODE_UNKNOWN; } -const RawModeData * const getRawModeData(const RawModeID id) { +const RawModeData *const +getRawModeData(const RawModeID id) { if (id < 0 || id > sizeof(RAWMODES) / sizeof(*RAWMODES)) { return &RAWMODES[IMAGING_RAWMODE_UNKNOWN]; } return &RAWMODES[id]; } - -int isModeI16(const ModeID mode) { - return mode == IMAGING_MODE_I_16 - || mode == IMAGING_MODE_I_16L - || mode == IMAGING_MODE_I_16B - || mode == IMAGING_MODE_I_16N; +int +isModeI16(const ModeID mode) { + return mode == IMAGING_MODE_I_16 || mode == IMAGING_MODE_I_16L || + mode == IMAGING_MODE_I_16B || mode == IMAGING_MODE_I_16N; } diff --git a/src/libImaging/Mode.h b/src/libImaging/Mode.h index e21ad941a26..a20ad0cb68d 100644 --- a/src/libImaging/Mode.h +++ b/src/libImaging/Mode.h @@ -1,7 +1,6 @@ #ifndef __MODE_H__ #define __MODE_H__ - typedef enum { IMAGING_MODE_UNKNOWN, @@ -35,12 +34,13 @@ typedef enum { } ModeID; typedef struct { - const char * const name; + const char *const name; } ModeData; -const ModeID findModeID(const char * const name); -const ModeData * const getModeData(const ModeID id); - +const ModeID +findModeID(const char *const name); +const ModeData *const +getModeData(const ModeID id); typedef enum { IMAGING_RAWMODE_UNKNOWN, @@ -226,13 +226,15 @@ typedef enum { } RawModeID; typedef struct { - const char * const name; + const char *const name; } RawModeData; -const RawModeID findRawModeID(const char * const name); -const RawModeData * const getRawModeData(const RawModeID id); - +const RawModeID +findRawModeID(const char *const name); +const RawModeData *const +getRawModeData(const RawModeID id); -int isModeI16(const ModeID mode); +int +isModeI16(const ModeID mode); -#endif // __MODE_H__ +#endif // __MODE_H__ diff --git a/src/libImaging/Pack.c b/src/libImaging/Pack.c index bb27d640ff2..8f21eab3aad 100644 --- a/src/libImaging/Pack.c +++ b/src/libImaging/Pack.c @@ -653,7 +653,8 @@ static struct { {IMAGING_MODE_I_16B, IMAGING_RAWMODE_I_16B, 16, copy2}, {IMAGING_MODE_I_16L, IMAGING_RAWMODE_I_16L, 16, copy2}, {IMAGING_MODE_I_16N, IMAGING_RAWMODE_I_16N, 16, copy2}, - {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16N, 16, packI16N_I16}, // LibTiff native->image endian. + {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16N, 16, packI16N_I16 + }, // LibTiff native->image endian. {IMAGING_MODE_I_16L, IMAGING_RAWMODE_I_16N, 16, packI16N_I16}, {IMAGING_MODE_I_16B, IMAGING_RAWMODE_I_16N, 16, packI16N_I16B}, {IMAGING_MODE_BGR_15, IMAGING_RAWMODE_BGR_15, 16, copy2}, diff --git a/src/libImaging/Paste.c b/src/libImaging/Paste.c index 54dd270e6f0..d4b973abc4d 100644 --- a/src/libImaging/Paste.c +++ b/src/libImaging/Paste.c @@ -450,11 +450,10 @@ fill_mask_L( } } else { - int alpha_channel = imOut->mode == IMAGING_MODE_RGBa || - imOut->mode == IMAGING_MODE_RGBA || - imOut->mode == IMAGING_MODE_La || - imOut->mode == IMAGING_MODE_LA || - imOut->mode == IMAGING_MODE_PA; + int alpha_channel = + imOut->mode == IMAGING_MODE_RGBa || imOut->mode == IMAGING_MODE_RGBA || + imOut->mode == IMAGING_MODE_La || imOut->mode == IMAGING_MODE_LA || + imOut->mode == IMAGING_MODE_PA; for (y = 0; y < ysize; y++) { UINT8 *out = (UINT8 *)imOut->image[y + dy] + dx * pixelsize; UINT8 *mask = (UINT8 *)imMask->image[y + sy] + sx; diff --git a/src/libImaging/Point.c b/src/libImaging/Point.c index b4415203a6c..b78873e0cf9 100644 --- a/src/libImaging/Point.c +++ b/src/libImaging/Point.c @@ -209,8 +209,8 @@ ImagingPointTransform(Imaging imIn, double scale, double offset) { Imaging imOut; int x, y; - if (!imIn || (imIn->mode != IMAGING_MODE_I && - imIn->mode != IMAGING_MODE_I_16 && imIn->mode != IMAGING_MODE_F)) { + if (!imIn || (imIn->mode != IMAGING_MODE_I && imIn->mode != IMAGING_MODE_I_16 && + imIn->mode != IMAGING_MODE_F)) { return (Imaging)ImagingError_ModeError(); } diff --git a/src/libImaging/TiffDecode.c b/src/libImaging/TiffDecode.c index 5c4c42f664c..fdbe1c1b3ec 100644 --- a/src/libImaging/TiffDecode.c +++ b/src/libImaging/TiffDecode.c @@ -246,10 +246,26 @@ _pickUnpackers( // We'll pick appropriate set of unpackers depending on planar_configuration // It does not matter if data is RGB(A), CMYK or LUV really, // we just copy it plane by plane - unpackers[0] = ImagingFindUnpacker(IMAGING_MODE_RGBA, bits_per_sample == 16 ? IMAGING_RAWMODE_R_16N : IMAGING_RAWMODE_R, NULL); - unpackers[1] = ImagingFindUnpacker(IMAGING_MODE_RGBA, bits_per_sample == 16 ? IMAGING_RAWMODE_G_16N : IMAGING_RAWMODE_G, NULL); - unpackers[2] = ImagingFindUnpacker(IMAGING_MODE_RGBA, bits_per_sample == 16 ? IMAGING_RAWMODE_B_16N : IMAGING_RAWMODE_B, NULL); - unpackers[3] = ImagingFindUnpacker(IMAGING_MODE_RGBA, bits_per_sample == 16 ? IMAGING_RAWMODE_A_16N : IMAGING_RAWMODE_A, NULL); + unpackers[0] = ImagingFindUnpacker( + IMAGING_MODE_RGBA, + bits_per_sample == 16 ? IMAGING_RAWMODE_R_16N : IMAGING_RAWMODE_R, + NULL + ); + unpackers[1] = ImagingFindUnpacker( + IMAGING_MODE_RGBA, + bits_per_sample == 16 ? IMAGING_RAWMODE_G_16N : IMAGING_RAWMODE_G, + NULL + ); + unpackers[2] = ImagingFindUnpacker( + IMAGING_MODE_RGBA, + bits_per_sample == 16 ? IMAGING_RAWMODE_B_16N : IMAGING_RAWMODE_B, + NULL + ); + unpackers[3] = ImagingFindUnpacker( + IMAGING_MODE_RGBA, + bits_per_sample == 16 ? IMAGING_RAWMODE_A_16N : IMAGING_RAWMODE_A, + NULL + ); return im->bands; } else { @@ -761,7 +777,9 @@ ImagingLibTiffDecode( if (extrasamples >= 1 && (sampleinfo[0] == EXTRASAMPLE_UNSPECIFIED || sampleinfo[0] == EXTRASAMPLE_ASSOCALPHA)) { - shuffle = ImagingFindUnpacker(IMAGING_MODE_RGBA, IMAGING_RAWMODE_RGBa, NULL); + shuffle = ImagingFindUnpacker( + IMAGING_MODE_RGBA, IMAGING_RAWMODE_RGBa, NULL + ); for (y = state->yoff; y < state->ysize; y++) { UINT8 *ptr = (UINT8 *)im->image[y + state->yoff] + diff --git a/src/libImaging/Unpack.c b/src/libImaging/Unpack.c index e3c19ee2ed0..cee5177fd85 100644 --- a/src/libImaging/Unpack.c +++ b/src/libImaging/Unpack.c @@ -1714,7 +1714,6 @@ static struct { {IMAGING_MODE_RGB, IMAGING_RAWMODE_G_16N, 16, band116L}, {IMAGING_MODE_RGB, IMAGING_RAWMODE_B_16N, 16, band216L}, - {IMAGING_MODE_RGBA, IMAGING_RAWMODE_R_16N, 16, band016L}, {IMAGING_MODE_RGBA, IMAGING_RAWMODE_G_16N, 16, band116L}, {IMAGING_MODE_RGBA, IMAGING_RAWMODE_B_16N, 16, band216L}, @@ -1841,13 +1840,16 @@ static struct { {IMAGING_MODE_I_16N, IMAGING_RAWMODE_I_16N, 16, copy2}, {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16B, 16, unpackI16B_I16}, - {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16N, 16, unpackI16N_I16}, // LibTiff native->image endian. - {IMAGING_MODE_I_16L, IMAGING_RAWMODE_I_16N, 16, unpackI16N_I16}, // LibTiff native->image endian. + {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16N, 16, unpackI16N_I16 + }, // LibTiff native->image endian. + {IMAGING_MODE_I_16L, IMAGING_RAWMODE_I_16N, 16, unpackI16N_I16 + }, // LibTiff native->image endian. {IMAGING_MODE_I_16B, IMAGING_RAWMODE_I_16N, 16, unpackI16N_I16B}, {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_16R, 16, unpackI16R_I16}, - {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_12, 12, unpackI12_I16} // 12 bit Tiffs stored in 16bits. + {IMAGING_MODE_I_16, IMAGING_RAWMODE_I_12, 12, unpackI12_I16 + } // 12 bit Tiffs stored in 16bits. }; ImagingShuffler