Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pillow 5.4.1 #3535

Closed
27 tasks done
hugovk opened this issue Jan 3, 2019 · 14 comments
Closed
27 tasks done

Release Pillow 5.4.1 #3535

hugovk opened this issue Jan 3, 2019 · 14 comments
Assignees
Labels

Comments

@hugovk
Copy link
Member

hugovk commented Jan 3, 2019

Follow on from 5.4.0 (#3391).

TODO:

Point Release

Released as needed for security, installation or critical bug fixes.

  • Make necessary changes in master branch.
  • Update CHANGES.rst.
  • Cherry pick individual commits from master branch to release branch e.g. 5.4.x.
  • Check Travis CI to confirm passing tests in release branch e.g. 5.4.x.
  • Check out release branch e.g.:
    git checkout -t remotes/origin/5.4.x
  • In compliance with PEP 440, update version identifier in src/PIL/_version.py
  • Run pre-release check via make release-test.
  • Create tag for release e.g.:
    $ git tag 5.4.1
    $ git push --tags
  • Create source distributions e.g.:
    $ make sdist

Binary Distributions

Windows

Mac and Linux

    $ git clone https://github.com/python-pillow/pillow-wheels
    $ cd pillow-wheels
    $ git submodule init
    $ git submodule update Pillow
    $ cd Pillow
    $ git fetch --all
    $ git checkout [[release tag]]
    $ cd ..
    $ git commit -m "Pillow -> 5.4.1" Pillow
    $ git push

Publicize Release

Documentation

  • Make sure the default version for Read the Docs is the latest tagged release e.g. d2d43879 (5.4.1)
@hugovk hugovk added the Release label Jan 3, 2019
@hugovk
Copy link
Member Author

hugovk commented Jan 3, 2019

Thoughts on including the PNG "IDAT chunks after image end" regression?

#3527 / PR #3532

@aclark4life
Copy link
Member

@wiredfool ^^^ ?

@wiredfool
Copy link
Member

Yeah, it's a regression. It's been reported, we have a fix, we're doing the release. Put it in.

@hugovk
Copy link
Member Author

hugovk commented Jan 4, 2019

Added to the list. I'll do the release this weekend.

@radarhere
Copy link
Member

#3540? In #3536, an OSError: cannot identify image file became ValueError: seek of closed file in 5.4.0.

@hugovk
Copy link
Member Author

hugovk commented Jan 5, 2019

#3540? In #3536, an OSError: cannot identify image file became ValueError: seek of closed file in 5.4.0.

If there's no objections by tomorrow, let's include it. Please could you update the 5.4.1 release notes?

@hugovk
Copy link
Member Author

hugovk commented Jan 5, 2019

A question about the release checklist for point releases:

...

  • Cherry pick individual commits from master branch to release branch e.g. 5.2.x.
  • Check Travis CI to confirm passing tests in release branch e.g. 5.2.x.
  • Check out release branch e.g.:
    git checkout -t remotes/origin/5.2.x
  • In compliance with PEP 440, update version identifier in src/PIL/_version.py

...

Presumably that git checkout -t remotes/origin/5.2.x should really come before the cherry picks?

@aclark4life
Copy link
Member

@hugovk Sounds about right. I don't think you can specify a target branch when cherry-picking …

@hugovk
Copy link
Member Author

hugovk commented Jan 6, 2019

@cgohlke Please could we have Windows binaries for 5.4.1?

@cgohlke
Copy link
Contributor

cgohlke commented Jan 6, 2019

Here you go.

@hugovk
Copy link
Member Author

hugovk commented Jan 6, 2019

@cgohlke Thanks!


5.4.1 is all uploaded and released, bar Twitter and Read the Docs.

RTD has got jammed again... I've started a manual build of stable.

image

@hugovk
Copy link
Member Author

hugovk commented Jan 6, 2019

The RTD build completed, but it's not showing up yet.

https://pillow.readthedocs.io/ redirects to stable:

https://readthedocs.org/projects/pillow/versions/ shows the same commit f38f01b for stable and 5.4.1:

image

But 5.4.1 isn't showing here:

@radarhere
Copy link
Member

5.4.1 is now showing at https://pillow.readthedocs.io/en/stable/releasenotes/index.html

@hugovk
Copy link
Member Author

hugovk commented Jan 6, 2019

RTD seems to have sorted itself out.

So, all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants