Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRIO112 false alarm on strict_exception_groups #138

Closed
jakkdl opened this issue Feb 14, 2023 · 1 comment
Closed

TRIO112 false alarm on strict_exception_groups #138

jakkdl opened this issue Feb 14, 2023 · 1 comment

Comments

@jakkdl
Copy link
Member

jakkdl commented Feb 14, 2023

  • TRIO112: nursery body with only a call to nursery.start[_soon] and not passing itself as a parameter can be replaced with a regular function call.

Ah, but not if the nursery is passed strict_exception_groups=, because that would change exception types.

breaking out from #124 - in case the linter should also ignore those cases.

@Zac-HD
Copy link
Member

Zac-HD commented Feb 14, 2023

Hmm, I think it's OK to raise a lint error (which can be noqa'd) since this is kinda weird, I just wouldn't want to automatically change the code when we could instead avoid breaking changes 😅

@Zac-HD Zac-HD closed this as completed Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants