Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default no-checkpoint-warning-decorators #313

Open
jakkdl opened this issue Nov 8, 2024 · 0 comments
Open

default no-checkpoint-warning-decorators #313

jakkdl opened this issue Nov 8, 2024 · 0 comments

Comments

@jakkdl
Copy link
Member

jakkdl commented Nov 8, 2024

#309 (comment)

I'm also inclined to include FastAPI support in the default no-checkpoint-decorators; reducing the low-value-alarm rate for users is more important than my personal distaste for missing checkpoints 😅. That can easily go in a future PR though.

hrm. suppressing it for async124 makes lots of sense, but less so for async9xx... if they got suppressed for cases where async124 would get suppressed >_<
I guess that's a point in favor of default-disabling it for async124 in particular regardless of no-checkpoint-decorator

also probably suppress async9xx for functions where async124 triggers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant