Skip to content

Commit

Permalink
Just use git for checkout (#506)
Browse files Browse the repository at this point in the history
actions/checkout is repeatedly flaky

See also actions/checkout#1951

On the other hand, plain git clone seems to work just fine and never has
connection issues checking out the default branch

Funnily enough, the YAML is shorter this way too
  • Loading branch information
hauntsaninja authored Nov 17, 2024
1 parent e888dfd commit bf9a252
Showing 1 changed file with 52 additions and 67 deletions.
119 changes: 52 additions & 67 deletions .github/workflows/third_party.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,27 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout pydantic
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
repository: pydantic/pydantic
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Checkout pydantic
run: git clone https://github.com/pydantic/pydantic.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Install uv
uses: astral-sh/setup-uv@v3
- name: Set up Python ${{ matrix.python-version }}
run: uv python install ${{ matrix.python-version }}
- name: Add local version of typing_extensions as a dependency
run: uv add --editable ./typing-extensions-latest
run: cd pydantic; uv add --editable ../typing-extensions-latest
- name: Install pydantic test dependencies
run: uv sync --group dev
run: cd pydantic; uv sync --group dev
- name: List installed dependencies
run: uv pip list
run: cd pydantic; uv pip list
- name: Run pydantic tests
run: uv run pytest
run: cd pydantic; uv run pytest

typing_inspect:
name: typing_inspect tests
Expand All @@ -88,21 +89,18 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout typing_inspect
uses: actions/checkout@v4
with:
repository: ilevkivskyi/typing_inspect
path: typing_inspect
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Checkout typing_inspect
run: git clone https://github.com/ilevkivskyi/typing_inspect.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Install typing_inspect test dependencies
run: |
set -x
Expand Down Expand Up @@ -136,22 +134,19 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Check out pyanalyze
uses: actions/checkout@v4
with:
repository: quora/pyanalyze
path: pyanalyze
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Check out pyanalyze
run: git clone https://github.com/quora/pyanalyze.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Install pyanalyze test requirements
run: |
set -x
Expand Down Expand Up @@ -185,22 +180,19 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Check out typeguard
uses: actions/checkout@v4
with:
repository: agronholm/typeguard
path: typeguard
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Check out typeguard
run: git clone https://github.com/agronholm/typeguard.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Install typeguard test requirements
run: |
set -x
Expand Down Expand Up @@ -235,21 +227,18 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Check out typed-argument-parser
uses: actions/checkout@v4
with:
repository: swansonk14/typed-argument-parser
path: typed-argument-parser
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Check out typed-argument-parser
run: git clone https://github.com/swansonk14/typed-argument-parser.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Configure git for typed-argument-parser tests
# typed-argument parser does this in their CI,
# and the tests fail unless we do this
Expand Down Expand Up @@ -290,22 +279,19 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout mypy for stubtest and mypyc tests
uses: actions/checkout@v4
with:
repository: python/mypy
path: mypy
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
allow-prereleases: true
- name: Install uv
run: curl -LsSf https://astral.sh/uv/install.sh | sh
- name: Checkout mypy for stubtest and mypyc tests
run: git clone https://github.com/python/mypy.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Install mypy test requirements
run: |
set -x
Expand Down Expand Up @@ -341,30 +327,29 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- name: Checkout cattrs
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
repository: python-attrs/cattrs
python-version: ${{ matrix.python-version }}
- name: Checkout cattrs
run: git clone https://github.com/python-attrs/cattrs.git
- name: Checkout typing_extensions
uses: actions/checkout@v4
with:
path: typing-extensions-latest
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install pdm for cattrs
run: pip install pdm
- name: Add latest typing-extensions as a dependency
run: |
cd cattrs
pdm remove typing-extensions
pdm add --dev ./typing-extensions-latest
pdm add --dev ../typing-extensions-latest
- name: Install cattrs test dependencies
run: pdm install --dev -G :all
run: cd cattrs; pdm install --dev -G :all
- name: List all installed dependencies
run: pdm list -vv
run: cd cattrs; pdm list -vv
- name: Run cattrs tests
run: pdm run pytest tests
run: cd cattrs; pdm run pytest tests

create-issue-on-failure:
name: Create an issue if daily tests failed
Expand Down

0 comments on commit bf9a252

Please sign in to comment.