You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once a PR is released, I expect that MSR will leave a comment on that PR, for only the package that was released, and only the one comment for the release that PR went out in.
Actual behavior
MSR is leaving comments on PRs repeatedly for every single publish, even for packages that the PR was not scoped as. On my work repo it's doing this on a dozen PRs every release.
Oh, that's really annoying side-effect. But, I'm afraid, msr is just a runner/wrapper for semrel, so we cannot fully control its inners, plugins, etc. Our solution is not elegant: we disabled this plugin option.
@antongolub Ah bummer, I was hoping maybe this was just something getting confused between MSR and SR. Okay, well at least there's now an issue for others to find. I'll probably disable it as well.
Issue type
Expected behavior
Once a PR is released, I expect that MSR will leave a comment on that PR, for only the package that was released, and only the one comment for the release that PR went out in.
Actual behavior
MSR is leaving comments on PRs repeatedly for every single publish, even for packages that the PR was not scoped as. On my work repo it's doing this on a dozen PRs every release.
Example: Twipped/monorepo-sandbox#2
Steps to reproduce
Reproduction repo here: https://github.com/Twipped/monorepo-sandbox/
SR config is here: https://github.com/Twipped/semrel-config
Specifications
The text was updated successfully, but these errors were encountered: