Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate release comments on old PRs #82

Open
3 of 6 tasks
Twipped opened this issue Jul 15, 2022 · 2 comments
Open
3 of 6 tasks

Duplicate release comments on old PRs #82

Twipped opened this issue Jul 15, 2022 · 2 comments

Comments

@Twipped
Copy link

Twipped commented Jul 15, 2022

Issue type

  • bug report
  • idea
  • question
  • other

Expected behavior

Once a PR is released, I expect that MSR will leave a comment on that PR, for only the package that was released, and only the one comment for the release that PR went out in.

Actual behavior

MSR is leaving comments on PRs repeatedly for every single publish, even for packages that the PR was not scoped as. On my work repo it's doing this on a dozen PRs every release.

Example: Twipped/monorepo-sandbox#2

  • I've read the docs. This case is not mentioned
  • Similar issue does not exist

Steps to reproduce

Reproduction repo here: https://github.com/Twipped/monorepo-sandbox/
SR config is here: https://github.com/Twipped/semrel-config

Specifications

  • version: MSR 6.5.1, Node v16.14.0
  • platform: ubuntu
  • ci: Github Actions
@antongolub
Copy link
Member

Oh, that's really annoying side-effect. But, I'm afraid, msr is just a runner/wrapper for semrel, so we cannot fully control its inners, plugins, etc. Our solution is not elegant: we disabled this plugin option.

https://github.com/qiwi/semantic-release-toolkit/blob/master/packages/config-monorepo/src/main/js/index.js#L29

@Twipped
Copy link
Author

Twipped commented Jul 18, 2022

@antongolub Ah bummer, I was hoping maybe this was just something getting confused between MSR and SR. Okay, well at least there's now an issue for others to find. I'll probably disable it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants