Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to zurk causes CI failure #282

Closed
3 of 6 tasks
jeswr opened this issue Dec 9, 2024 · 3 comments
Closed
3 of 6 tasks

Migration to zurk causes CI failure #282

jeswr opened this issue Dec 9, 2024 · 3 comments

Comments

@jeswr
Copy link

jeswr commented Dec 9, 2024

Issue type

  • bug report
  • idea
  • question
  • other

Expected behavior

GH Pages to continue to be published as usual

Actual behavior

Fails with error TypeError: (0 , zurk_1.$)(...)(...).catch is not a function. An example of such a failing job can be found at https://github.com/eyereasoner/eye-js/actions/runs/12236225074/job/34129931769

  • I've read the docs. This case is not mentioned
  • Similar issue does not exist

Steps to reproduce

See https://github.com/eyereasoner/eye-js/actions/runs/12236225074/job/34129931769

Specifications

See https://github.com/eyereasoner/eye-js/blob/d07fb2207619a3d785b4befcb93e68761b73ae67/.github/workflows/nodejs.yml#L110-L141

@antongolub
Copy link
Member

Wow! This is how tsc compiles

$`cmd`.catch
return (0, zurk_1.$)({
        env: opts.env,
        cwd: opts.cwd,
        shell: false
    })(templateObject_1 || (templateObject_1 = tslib_1.__makeTemplateObject(["git pull --tags --force ", " ", ""], ["git pull --tags --force ", " ", ""])), repo, pullTagsBranch).catch(console.error);

@antongolub
Copy link
Member

antongolub commented Dec 9, 2024

zurk internal isTemplateLiteral check fails for tslib-generated literals.

The root cause: microsoft/tslib#277

@antongolub
Copy link
Member

@jeswr,

v5.4.1 is on the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants