Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeouts to tests #398

Open
shubhamtagra opened this issue May 29, 2020 · 0 comments
Open

Add timeouts to tests #398

shubhamtagra opened this issue May 29, 2020 · 0 comments

Comments

@shubhamtagra
Copy link

Noticed that CI tests somehow get stuck, one of the runs was stuck in TestBookKeeperFactory in Waiting for MockBookKeeperServer to come up when the MockBookKeeperServer had failed to come up due to java.net.BindException: Address already in use (Bind failed).

We need to do two things:

  1. Tests which wait for server to come up should handle failure in server start instead of endless wait
  2. As a failsafe, all tests should run with a timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant