Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitcreds_set() should check to make sure a credential helper is configured #54

Open
tanho63 opened this issue Nov 30, 2023 · 1 comment
Labels
feature a feature request or enhancement

Comments

@tanho63
Copy link

tanho63 commented Nov 30, 2023

Hi! Fresh-starting a machine and was following the usethis guide, but ran into an issue where I forgot to set the credential helper to something before trying to set credentials via gitcreds::gitcreds_set():

R> gitcreds::gitcreds_list_helpers()
Error in new_git_error("git_error", args = args, stdout = out, status = attr(out,  : 
  System git failed: 
R> gitcreds::gitcreds_set()


? Enter password or token: my_github_token
-> Adding new credentials...
-> Removing credentials from cache...
-> Done.
R> gitcreds::gitcreds_get()
Error in throw(new_error("gitcreds_no_credentials", url = url)) : 
  Could not find any credentials

Should gitcreds_set() check to make sure at least one credential helper is configured before trying to set the credential?

@gaborcsardi
Copy link
Member

That would indeed make sense. I have a feeling that this won't be easy to implement, but we should at least investigate.

@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants