Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed library to use background loop instead of manually looping #27

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

juha-ylikoski
Copy link

Addresses #25

This pull requests tries to fix problems with mqtt broker suddenly disconnecting. #4 thinks it might be related to looping mechanism somehow not working properly with robot.

Changes

TODO

Some pub/sub test cases are still failing. This is caused by them being synchronous.

Example:

Test case Publish a message with QOS 1 and validate that the message is received first sends a message to broker and reconnects, subscribes and tries to receive it. Due to this case using synchronous Subscribe And Validate message which was sent before has already timed out and cannot be received.

@juha-ylikoski
Copy link
Author

@randomsync what is your opinion on these test cases failing due to them being synchronous when they maybe should not be. I could make them asynchronous but I'm not sure how we could test synchronous receiving (in my opinion it is too time sensitive and prone to failures).

Github is not letting me to include log.html but travis should have one shortly with the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant