skip cert writing and variable setting if concat certs starts with ; #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem being approached here is how to handle the absence of certificates. The input of certificates looks like:
If these secrets are not set, they'll just evaluate as empty, so our
cert_concat
value should come out looking like;;
. This startsWith test should work, as should many other simple string comparisons. The cleanest way is probably to try a different way of setting the input to cert_concat, such that it is an empty string when the variables are not set. That is left for a future exercise, because this cert code is likely to go away soon anyway. We don't really want to be using certs.