Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customisable Fonts for themes #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

giridharvc7
Copy link

Added an option to customise font in theme.

Theme is now customizable with font.
@raspu
Copy link
Owner

raspu commented Oct 7, 2018

Hi thank you for your PR.
I understand why this may be useful, but the setCodeFont method on the Theme object is documented to explain what is happening internally and how can you further customize the theme fonts, this is important because there may be fonts that doesn't include the required variations (italic and bold) and if the user use them as argument the resulting product may no look as expected, with this change there's no clear indication on how to solve an issue like that.

To be honest, I am not really happy with current the setTheme method, I would like to change it to receive an initialized Theme rather than a theme name, so you can properly configure it before passing it.

@giridharvc7
Copy link
Author

I understand.
Would wrapping bold, italics and regular font in a struct and passing it as an argument do the trick? I understand this is might not look good, but I cannot think of another way either 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants