Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix uuid during testing #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hedrall
Copy link

@hedrall hedrall commented Feb 24, 2022

How about fixing the UUID by referring to NODE_ENV?

In my test environment, import rc-dialog only once (via antd), so the snapshot test will show the difference.

スクリーンショット 2022-02-25 6 51 20

@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/dialog/82aAcdjVNct2a4Kk24JeftJnGx2b
✅ Preview: https://dialog-git-fork-hedrall-feature-fix-uuid-ff71f9-react-component.vercel.app

@hedrall hedrall changed the title fix uuid when test Fix uuid during testing Feb 24, 2022
@hedrall hedrall changed the title Fix uuid during testing fix: Fix uuid during testing Feb 24, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #282 (c9eec35) into master (65f1f8c) will decrease coverage by 1.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
- Coverage   98.12%   96.91%   -1.22%     
==========================================
  Files           6        6              
  Lines         160      162       +2     
  Branches       47       48       +1     
==========================================
  Hits          157      157              
- Misses          2        4       +2     
  Partials        1        1              
Impacted Files Coverage Δ
src/util.ts 92.85% <100.00%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f1f8c...c9eec35. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant