Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event.which is deprecated which causes issues when using @testling-library/user-event v14 #977

Open
kapiljaveri opened this issue Aug 30, 2023 · 1 comment
Open

event.which is deprecated which causes issues when using @testling-library/user-event v14 #977

kapiljaveri opened this issue Aug 30, 2023 · 1 comment

Comments

@kapiljaveri
Copy link

https://developer.mozilla.org/en-US/docs/Web/API/UIEvent/which

Issue found here - testing-library/user-event#1137

It's recommended to switch over to event.code or event.key instead - testing-library/user-event#842 (comment)
@kapiljaveri
Copy link
Author

Probably looks like we also need to change - https://github.com/react-component/util/blob/master/src/KeyCode.ts

@chilled-capybara chilled-capybara mentioned this issue Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kapiljaveri