-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"render" function throws "reactRender is not a function" with react 19-rc #550
Comments
I can confirm the issue by patching diff --git a/es/React/render.js b/es/React/render.js
index 169f01b2998a21ba42fa7b7a397ee526ad2aacb4..62793f70ab5e9d9488800b8dd3a866c67a14a943 100644
--- a/es/React/render.js
+++ b/es/React/render.js
@@ -2,7 +2,7 @@ import _regeneratorRuntime from "@babel/runtime/helpers/esm/regeneratorRuntime";
import _asyncToGenerator from "@babel/runtime/helpers/esm/asyncToGenerator";
import _typeof from "@babel/runtime/helpers/esm/typeof";
import _objectSpread from "@babel/runtime/helpers/esm/objectSpread2";
-import * as ReactDOM from 'react-dom';
+import * as ReactDOM from 'react-dom/client';
// Let compiler not to search module usage
var fullClone = _objectSpread({}, ReactDOM);
var version = fullClone.version,
|
so is this going to be fixed? |
I am waiting for a fix 😂 |
+1 |
with the release of next 15 this has become annoying |
me too |
@rendeyuwei you are actually wrong: there is a split before the Number call so that particular line works just fine. |
Sorry, I made a simple mistake, but the error still exists. |
Yep, for me the patch to |
@zombieJ can you please take a look? thanks. |
Hi everyone, I'm currently working on a project testing the new release candidate version of react 19. I noticed that when calling the
render
function defined here it throws the errorreactRender is not a function
. It looks likecreateRoot
is not found when used with react 19-RC and this leads to use thelegacyRender
that of course will not work.I suspect there's some problem related on how
createRoot
it's imported, here the official reference from react where it's imported fromreact-dom/client
and not fromreact-dom
.Thanks in advance for the support!
The text was updated successfully, but these errors were encountered: