Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can I convert these to new version? like React Navigation is 5.x now. #68

Open
simonsheng opened this issue Jun 19, 2020 · 7 comments
Open

Can I convert these to new version? like React Navigation is 5.x now. #68

simonsheng opened this issue Jun 19, 2020 · 7 comments
Assignees
@simonsheng
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@simonsheng
Copy link

Name your screen design
I can start from Plant-App.
@hetmann
Copy link
Contributor

hetmann commented Jun 19, 2020

@simonsheng thank you for your support. Lets do it!

@hetmann hetmann added enhancement New feature or request help wanted Extra attention is needed labels Jun 19, 2020
@simonsheng
Copy link
Author

I am going to duplicate plant-app folder, do you have a folder/project name? Is plant-app-react-navigation-5.x ok? since it's better keep the 4.x version

@hetmann
Copy link
Contributor

hetmann commented Jun 19, 2020

I am going to duplicate plant-app folder, do you have a folder/project name? Is plant-app-react-navigation-5.x ok? since it's better keep the 4.x version

Thank you. You can clone the whole repository, create a new branch "plant-app-react-navigation-5" and after you finish the implementation you can create a pull request.

@simonsheng
Copy link
Author

simonsheng commented Jun 19, 2020 •
edited
Loading

Ok, I will create that new branch.

@simonsheng
Copy link
Author

I don't think I have permission to do branch things.

@hetmann
Copy link
Contributor

hetmann commented Jun 19, 2020

I don't think I have permission to do branch things.

You can clone the repo on your account and create a PR from your repo :)

@simonsheng
Copy link
Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonsheng simonsheng

Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hetmann @simonsheng