Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: allow users to close it #384

Open
jidanni opened this issue Sep 20, 2024 · 2 comments
Open

Flyout: allow users to close it #384

jidanni opened this issue Sep 20, 2024 · 2 comments
Labels
Needed: design decision A core team decision is required

Comments

@jidanni
Copy link

jidanni commented Sep 20, 2024

All I know is I am browsing
https://gdal.org/en/latest/drivers/vector/libkml.html
and in the lower right corner of the screen there is this:
Screenshot 2024-09-20 08 43 29
blocking text.

It's just like when I'm riding the bus and there is a bumper sticker blocking my vision when I look out the window.

No matter how I clicked, I could only make it bigger. I could not make it go away.

You might think "no big deal", but on my small screen it is blocking text and very annoying.

No I don't know who owns the website, and do not write documentation.

At least let people close it.

@jidanni jidanni added Bug A bug Needed: replication Bug replication is required labels Sep 20, 2024
@humitos
Copy link
Member

humitos commented Sep 23, 2024

Thanks for opening this issue. I'm transferring it to the addons repository since this flyout is generated by Read the Docs Addons.

We will need to discuss this more internally, but I think it's probably a good idea to have a simple way to close the flyout. Maybe it does not have to be shown all the time, but only on hover.

@humitos humitos transferred this issue from readthedocs/sphinx_rtd_theme Sep 23, 2024
@humitos humitos added Needed: design decision A core team decision is required and removed Bug A bug Needed: replication Bug replication is required labels Sep 23, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Sep 23, 2024
@humitos humitos changed the title Allow closing the rectangle in the lower right corner of the screen Flyout: allow users to close it Sep 25, 2024
@humitos
Copy link
Member

humitos commented Oct 3, 2024

We had a discussion yesterday about this issue and these are some of the notes I was able to take.

Possible solution we discussed:

  • Collapse the flyout: it could have a small UI element (maybe a dropdown icon) that allows the users to collapse the flyout even more that its current "collapsed version" and reduce it to a small Read the Docs icon/logo. This "reduced to an icon" state could be maybe the default behavior for mobile/small screens
  • Attach it to the bottom of the page: create a new layout for mobile/small screens that is attached to the bottom of the page; in a similar way of how text ad works for the Ethical Ad client

These and other solutions would be considered when working on the next iteration of the flyout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: design decision A core team decision is required
Projects
Status: Planned
Development

No branches or pull requests

2 participants