Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EthicalAd: keeps showing on 404 pages #386

Closed
humitos opened this issue Sep 25, 2024 · 1 comment · Fixed by #430
Closed

EthicalAd: keeps showing on 404 pages #386

humitos opened this issue Sep 25, 2024 · 1 comment · Fixed by #430
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Sep 25, 2024

The ad is still showing at https://sphinx-rtd-theme.readthedocs.io/en/notfound/ but it shouldn't. I think it's because we are not calling super() on isEnabled(config) method at:

addons/src/ethicalads.js

Lines 321 to 325 in 2c19271

static isEnabled(config) {
return (
super.isEnabled(config) && config.addons.ethicalads.ad_free === false
);
}

@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Sep 25, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Sep 25, 2024
@humitos
Copy link
Member Author

humitos commented Oct 10, 2024

I'm not able to reproduce the issue in the link from the description. However, this custom 404 page keeps showing the ad https://docs.godotengine.org/en/latest/page-not-found/

This is somehow related with another one where we need to define what to do on custom 404 pages:

@humitos humitos mentioned this issue Nov 11, 2024
Merged
humitos added a commit that referenced this issue Nov 12, 2024
@humitos
EthicalAds: don't show ad on 404 pages (#430)
bff2f37 
It seems the `isEnabled` method wasn't updated to accept the
`httpStatus` and that's why it wasn't working fine.

Now, the Ad won't be shown on pages like this one:
https://sphinx-rtd-theme.readthedocs.io/en/stable/notfound

Related #385
Closes #386
@github-project-automation github-project-automation bot moved this from Planned to Done in 📍Roadmap Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
📍Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EthicalAds: don't show ad on 404 pages readthedocs/addons
1 participant
@humitos