Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: history not always retained #399

Open
thephez opened this issue Oct 9, 2024 · 0 comments
Open

Search: history not always retained #399

thephez opened this issue Oct 9, 2024 · 0 comments
Assignees
Labels
Bug A bug

Comments

@thephez
Copy link

thephez commented Oct 9, 2024

I like the search history feature in the addon; however, it seems to only track searches where I click on a result with my mouse. When using the arrow keys and pressing enter to open a result, those searches are not remembered the next time I open the screen. Also, when clicking on a page title instead of the actual item, those searches are not remembered either.

In this screen capture, I

  1. Select a response using arrows/enter
  2. Select a response by clicking the page
  3. Select a response by clicking the actual item

The search history is only retained after the last one.

rtd-search-history.mp4

I should note that I'm doing some custom stuff to make this work with pydata-sphinx-theme; however, I also tested using the addons / hotkey also and get the same results regardless of how the modal is opened.

@humitos humitos added the Bug A bug label Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Oct 9, 2024
@humitos humitos changed the title Search history not always retained Search: history not always retained Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
Status: Planned
Development

No branches or pull requests

3 participants