Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docdiff: showing mathjax that didn't change as changes #404

Open
sciencewhiz opened this issue Oct 12, 2024 · 1 comment
Open

Docdiff: showing mathjax that didn't change as changes #404

sciencewhiz opened this issue Oct 12, 2024 · 1 comment
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@sciencewhiz
Copy link

My project uses sphinx.ext.mathjax. When there is no change in content, docdiff still shows a change. The docdiff appears to be comparing the unrendered mathjax in the old version to the rendered output.

image

Here's a link to the PR build that shows this: https://frc-docs--2785.org.readthedocs.build/en/2785/docs/software/advanced-controls/state-space/state-space-flywheel-walkthrough.html

@humitos
Copy link
Member

humitos commented Oct 12, 2024

The docdiff appears to be comparing the unrendered mathjax in the old version to the rendered output.

I think this is the problem, yeah. We load the DOM of the original file without processing it (no JS ran over it). However, the current DOM is loaded after running all the scripts.

I think we should be able to load the current DOM before performing any JS operations.

@humitos humitos changed the title docdiff, showing mathjax that didn't change as changes Docdiff: showing mathjax that didn't change as changes Oct 14, 2024
@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants