Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link previews: sending url=undefined sometimes #432

Open
humitos opened this issue Nov 13, 2024 · 0 comments
Open

Link previews: sending url=undefined sometimes #432

humitos opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug A bug

Comments

@humitos
Copy link
Member

humitos commented Nov 13, 2024

Today I found that if you:

  1. go to https://test-builds.readthedocs.io/en/full-feature/shot-scraper.html
  2. hover on any of those 3 links
  3. you get an error in the console

That's OK because they are external URLs and the backend should block them.

However, when taking a deeper look at the error, it seems the problem is at the JS level because the url= attribute sent to the backend API is undefined instead the real href from the HTML a tag.

The URL hit should be https://test-builds.readthedocs.io/_/api/v3/embed/?url=https://datasette.io/ and the error reported should be External domain not allowed. domain=datasette.io".

@zanderle can you take a look at this? 🙏🏼

@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Nov 13, 2024
@humitos humitos added Bug A bug Accepted Accepted issue on our roadmap labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug A bug
Projects
Status: Planned
Development

No branches or pull requests

2 participants