Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Filtering -> ES events filtering issues #4

Open
theevilbit opened this issue Apr 17, 2023 · 2 comments
Open

Artifact Filtering -> ES events filtering issues #4

theevilbit opened this issue Apr 17, 2023 · 2 comments
Assignees
Labels
accepted-request This feature request has been initially accepted. We'll start digging. rc-mac-feature-request

Comments

@theevilbit
Copy link

Describe the bug
When I remove an event from the Artifact Filtering -> ES events to see it in the view, I can't add it back. I need to fully disable filtering and reenable it to be able to filter out the event.

Expected behavior
When I click "remove", there should be a button to "add".

To Reproduce
Steps to reproduce the behavior:

  1. Enable artifact filtering
  2. remove an item

Platform specifics (please complete the following information):

  • macOS version 13.3.1
  • Architecture Intel
  • Version 1.0.1 (1)
@Brandon7CC
Copy link
Contributor

Brandon7CC commented Apr 17, 2023

Also correct!

@theevilbit Along a similar line... would you like a right click "focus related events" button? This would remove all but the related events (by initiating process / target process for exec/fork)? This should also be a easier ask 😄

@Brandon7CC Brandon7CC added the accepted-request This feature request has been initially accepted. We'll start digging. label Apr 17, 2023
@Brandon7CC
Copy link
Contributor

@theevilbit after thinking more on this... this was the intended behavior. The original idea for the "event mask" would be that that it takes a "snapshot" of the events the user is subscribed to and then they have the ability to selectively remove from view. Adding them back would be taken care of by disabling and re-enabling the mask like you said.

I'm going to switch this from "bug" to "feature request". This will be a UI/UX change / feature addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted-request This feature request has been initially accepted. We'll start digging. rc-mac-feature-request
Projects
None yet
Development

No branches or pull requests

2 participants