Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Make is_supported model list user configurable #288

Open
sadsfae opened this issue Oct 29, 2019 · 1 comment
Open

[RFE] Make is_supported model list user configurable #288

sadsfae opened this issue Oct 29, 2019 · 1 comment

Comments

@sadsfae
Copy link
Member

sadsfae commented Oct 29, 2019

Is your feature request related to a problem? Please describe.

We currently keep a list of badfish-capable models (Dells) here:

https://github.com/redhat-performance/quads/blob/master/quads/config.py#L29

We also keep a list of supermicro types (to use ipmitool instead of badfish as you need a paid license to use badfish API on SuperMicro).

https://github.com/redhat-performance/quads/blob/master/quads/config.py#L30

When adding support for new models, or naming conventions that might not pattern-match the ones we have included it would require editing the config.py list.

Describe the solution you'd like

It's OK to have a baseline set of systems kept in config.py probably, but this should also be user-configurable to include additional models or types in /opt/quads/conf/quads.yml

Then, when quads-server is started and quads.yml is parsed into memory it should append the existing lists of SUPPORTED and SUPERMICRO respectively with the example user input below.

Placing duplicate model strings should pick the first one and not cause an error if it already exists in config.py already.

e.g.

badfish_supported_dell: 740xd, 940, r940
badfish_supported_supermicro:  6029p, 1028r
@sadsfae
Copy link
Member Author

sadsfae commented Sep 23, 2024

related-to: #523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant