Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API v1 Feature Planning #2

Open
jmwample opened this issue Oct 18, 2023 · 2 comments
Open

API v1 Feature Planning #2

jmwample opened this issue Oct 18, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jmwample
Copy link
Member

Lets use this issue to plan the features that we are going to defer into the next version of the API so that we can focus on the required features for MVP release.

  • Wasm driven connection ( i.e. in Dial, Listen, or Relay mode)
  • Relay mode
  • Verbose errors returning strings (over memory / fd /pipe etc.)
  • ??
@jmwample jmwample added the enhancement New feature or request label Oct 18, 2023
@gaukas
Copy link
Contributor

gaukas commented Oct 18, 2023

just some clarification/suggestions:

Wasm driven connection

I guess better call it WebAssembly-managed Listener and Dialing Target. And perhaps we want to split them into individual bullet points.

TCP connections are already driven by WebAssembly in v0plus, since it is create upon being requested by the module and then the Worker() thread holds the ownership, do whatever it want.

In V1 we are allowing WebAssembly to wrap a TCP Listener (instead of asking host program accepting for it). Plus being able to specify the remote address to dial. We still need to figure out the API, since for Dial() provided by water in V1, it might still be meaningful for the caller to specify/recommend/override the target dialed by the module... we will figure this out later.

  • Relay mode

I think this can go into v0 (actual v0plus), I haven't test it yet but no reason this wouldn't work since Listen and Dial worked. I can test it out shortly.

@erikziyunchi
Copy link
Member

  • Wasm driven connection ( i.e. in Dial, Listen, or Relay mode)

On this the most important thing is we need a better way to communicate between Host & WASM where currently by using memory sharing is probably not good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants