-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1: WATM v1 driver #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SetDefaultLogger is now deprecated - SetDefaultLogHandler is now deprecated Signed-off-by: Gaukas Wang <[email protected]>
Signed-off-by: Gaukas Wang <[email protected]>
- Add DialManaged as a new interface which works like a dialer without remote address as input. - Naming is tentative. Signed-off-by: Gaukas Wang <[email protected]>
Starting v1 we seek to use memory-based file system instead of tmpfs for watm config. Signed-off-by: Gaukas Wang <[email protected]>
A new util for validating WATM-provided dialing destination address. Signed-off-by: Gaukas Wang <[email protected]>
Signed-off-by: Gaukas Wang <[email protected]>
Add additional cancellable wrapper around the input context to allow core-level cancellation. Signed-off-by: Gaukas Wang <[email protected]>
v1: rename, reformat, and regulate/standardize the function import/exports. Signed-off-by: Gaukas Wang <[email protected]>
erikziyunchi
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding v1! Maybe we can add some special / edge tests later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the draft driver for WebAssembly Transport Module version 1, which is expected to be the first stable version for WATER's WATM standards.