Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy/Security concern: make it clear that a report file is uploaded to https://semaphoreci.com/ #74

Open
thromera opened this issue Apr 25, 2020 · 2 comments

Comments

@thromera
Copy link

thromera commented Apr 25, 2020

I was exploring the codebase of this gem, and I noticed the module InsightsUploader, which uploads a report file to https://semaphoreci.com. (https://github.com/renderedtext/test-boosters/blob/master/lib/test_boosters/insights_uploader.rb#L20 )

If we focus only on the RSpec generated reports, the formatter adds all text contained in the "examples", AND the comments below the examples.
Example:

context 'my first context' do
  # This is a comment to explain my test 
  it 'does something' do
  end
end

reports

# Not sure of the finale uploaded file, it's basically a custom RSpec formatter. 
{
  context: {
    text: 'my first context',
    childs: [{
      it: {
        comment: 'This is a comment to explain my test',
        text: 'does something'
      }
    }]
  }
}

Reporting might be fine, as long as:

  • It is explicit for the user that data is being used, what data is exported, what's the point of exporting that data
  • there is an option to disable the reporting.
@thromera thromera changed the title Privacy concern: make it clear that a report file is uploaded to https://semaphoreci.com/ Privacy/Security concern: make it clear that a report file is uploaded to https://semaphoreci.com/ Apr 25, 2020
@pboling
Copy link

pboling commented Feb 3, 2021

@renderedtext Please consider this issue.

@pboling
Copy link

pboling commented Feb 9, 2021

Of note for future searchers of the web: there is a way to disable this on any systemd-compatible environment:

            mkdir -p $HOME/.local/bin
            touch $HOME/.local/bin/http && chmod +x $HOME/.local/bin/http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants