Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: volumeMounts for renovate-dind / option to provide /etc/docker/daemon.json #263

Closed
nobbs opened this issue Nov 10, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@nobbs
Copy link

nobbs commented Nov 10, 2022

Hey there, I've deployed the helm chart in our air-gapped on-prem cluster so that I can use renovate to manage helm chart dependencies against our private helm repositories and mirrors. That works fine when I use the "fat" renovate image and the option renovate config option binarySource to global (the default value install does not work, as there's no internet access thus tool installs failing).

I tried to use the dind option with binarySource: "docker" but had to scrape that as the docker daemon in the dind container tries to access docker.io for image pulls. As of now there is no option to modify the settings of the docker daemon inside the container, e.g. by providing a /etc/docker/daemon.json from a configmap or otherwise. If that would be possible, this would allow me to specify the internal docker registry mirror as a mirror to the docker daemon so that it would be able to grab the images.

Would appreciate it if this would be implemented - I could do it myself, too - just thought that a creating an issue first to get opinions would be good.

@nobbs nobbs changed the title Feature request: volumeMounts for renovate-dind / option to provide cat /etc/docker/daemon.json Feature request: volumeMounts for renovate-dind / option to provide /etc/docker/daemon.json Nov 10, 2022
@viceice
Copy link
Member

viceice commented Nov 10, 2022

Do you know dockerImagePrefix1? So you can force renovate to use images from your internal registry.

Footnotes

  1. https://docs.renovatebot.com/self-hosted-configuration/#dockerimageprefix

@viceice
Copy link
Member

viceice commented Nov 10, 2022

btw: the dind wouldn't help you, as renovate now uses the sidecar images and installs the tools on the fly for most managers, so needs again internet access.

@nobbs
Copy link
Author

nobbs commented Nov 10, 2022

Do you know dockerImagePrefix1? So you can force renovate to use images from your internal registry.

Ah, no, must have missed that option. Thanks. That's good enough.

Regarding your second comment, that's ... kind of unfortunate. But yeah, there's still the full image for now, too.

Thanks, feel free to close this then, as there's no need for this.

Footnotes

  1. https://docs.renovatebot.com/self-hosted-configuration/#dockerimageprefix

@viceice viceice closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@viceice
Copy link
Member

viceice commented May 16, 2023

@viceice viceice added the enhancement New feature or request label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants