Add input to specify PNG, JPEG, or WebP output formats #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it automatically saves as each image type based on the extension of the target filename? 🤔 |
Yes. This behavior comes from Pillow:
|
|
PNG and JPEG work correctly, but there's a bug in Cog around MIME types and data URI encoding/decoding that prevents WebP path outputs being saved to disk (at least when running `cog predict; I haven't tested running the model on Replicate). Converting to draft until that's resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75
Currently, predictions generate images in PNG format. This PR adds a new
formatinput that allows predictions to generate JPEG and WebP formats instead. If unspecified, the PNG is used by default.