Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set servername SNI, for tls socket #36

Open
odinho opened this issue Dec 13, 2017 · 0 comments
Open

Cannot set servername SNI, for tls socket #36

odinho opened this issue Dec 13, 2017 · 0 comments

Comments

@odinho
Copy link

odinho commented Dec 13, 2017

Hi,

The servername is hardcoded.

tunnel-agent/index.js

Line 203 in eb2b1b1

{ servername: options.host

It'd be nice to be able to set it.

Odin
@odinho odinho changed the title Cannot set servername for SNI tls socket Cannot set servername SNI, for tls socket Dec 13, 2017
odinho added a commit to hola/tunnel-agent that referenced this issue Dec 13, 2017
@odinho
Allow overriding SNI servername via options, fix request#36
0e10a07
seiya-git added a commit to seiya-npm/tunnel-agent that referenced this issue Sep 8, 2018
@seiya-git
Merge pull request #4 from hola/override_sni
8397037 
Allow overriding SNI servername via options, fix request#36
Hamper pushed a commit to seiya-npm/tunnel-agent that referenced this issue Sep 8, 2018
@odinho @Hamper
Allow overriding SNI servername via options, fix request#36
a0c9192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@odinho