Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM 6 - vulnerability - Memory Exposure #41

Open
ghost opened this issue May 16, 2018 · 21 comments
Open

NPM 6 - vulnerability - Memory Exposure #41

ghost opened this issue May 16, 2018 · 21 comments

Comments

@ghost
Copy link

ghost commented May 16, 2018

Moderate │ Memory Exposure │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ tunnel-agent │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.6.0 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ node-sass │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ node-sass > request > tunnel-agent │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://nodesecurity.io/advisories/598

@daniel-ac-martin
Copy link

Looks like this was fixed but the author neglected to publish v0.6.1 on NPM.

@thexpand
Copy link

thexpand commented Jun 4, 2018

When will v.0.6.1 be released on NPM?
https://www.npmjs.com/package/tunnel-agent

@igorescobar
Copy link

+1

@raitono
Copy link

raitono commented Jun 11, 2018

I'm seeing the fix in my version I got from NPM. Just seems the version number wasn't updated to match. It was a simple one line change, so you should easily be able to see if you have the fix as well. Check line 131 of the index.js file. Link to commit

@mattjbrent
Copy link

its been almost a month. Can we please get the NPM package version updated please?

@ghost
Copy link

ghost commented Jul 31, 2018

Please publish to NPM!?

@Pablo-Araya
Copy link

+1

@ianmubangizi
Copy link

Am totally new to the npm audit, I want to know if I can actually continue developing without applying this fix because I have tried updating to the latest 0.6.0 tunnel-agent package but it won't fix the warning.

@nvdlug
Copy link

nvdlug commented Aug 14, 2018

Please run npm publish

1 similar comment
@igorescobar
Copy link

Please run npm publish

@jasonkhanlar
Copy link

Is this safe to use without the npm publish ?

@yetzt
Copy link

yetzt commented Oct 10, 2018

can someone press npm publish on this? @mikeal @simov

@yetzt
Copy link

yetzt commented Oct 10, 2018

ah, i just saw, its broken downstream; nevermind.

@joshwilkerson
Copy link

+1 ☝️

@ghost
Copy link

ghost commented Dec 15, 2018

npm run publish 😭

@mikeal
Copy link
Member

mikeal commented Dec 16, 2018

There are no commits in this repo since the last release so I'm not sure exactly what it is that I'm meant to be releasing?

@coughlanio
Copy link

coughlanio commented Dec 17, 2018

@mikeal I think people are assuming there's a fix for the current NPM memory exposure audit error, why the version bump to 0.6.1 if there's no changes since 0.6.0?

 Moderate      │ Memory Exposure                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ tunnel-agent                                                 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.6.0                                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gatsby-plugin-sharp                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ gatsby-plugin-sharp > imagemin-webp > cwebp-bin >            │
│               │ bin-wrapper > download > caw > tunnel-agent                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://nodesecurity.io/advisories/598   

@mikeal
Copy link
Member

mikeal commented Dec 17, 2018

Odd release numbers don't get published, they are only in-tree, this makes it easier to see when people are using git checkouts rather than npm releases.

@sp90
Copy link

sp90 commented Jan 28, 2019

What is the status of this package?

@jasonkhanlar
Copy link

Oh my. I am still waiting on this to be fixed for npm also, re: #41

SEMVER WARNING: Recommended action is a potentially breaking change

@bakkerme
Copy link

bakkerme commented May 9, 2019

For everyone coming to this issue after seeing this in their npm audit, the latest version, v0.6.0 has patched this issue. Most likely, the reason you are seeing the advisory is because a dependency nested somewhere in your application is relying on an unpatched version of this package, likely many layers down.

In the example above, node-sass > request > tunnel-agent is the dependency chain that linked to the vulnerable tunnel-agent. You can see this chain under the Path header in npm audit. It's possible that every part of this chain needs to update their dependencies to fix the vulnerability.

Your best bet is to see if you're project's direct dependency, in this case node-sass, has updated their dependencies to a version that is fixed down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

16 participants