Show a warning on a cache access when a CachedSession
context manager has been exited
#290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
MRE
1st run (there is no cache file yet)
We can see the warning inside
get_connection()
after theyield
:2nd run (a cache file already exists)
We can see the warning inside the
def read()
:Notes
Not related to this PR and the mentioned issue, but Redis and MongoDB must have the
def close()
method too because the connections must be closed.