Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation from float to bigint #7089

Open
remitbri opened this issue Oct 7, 2024 · 1 comment
Open

Transformation from float to bigint #7089

remitbri opened this issue Oct 7, 2024 · 1 comment

Comments

@remitbri
Copy link

remitbri commented Oct 7, 2024

At the moment

let i = 1
let f = 1.3

let bigI = BigInt.fromInt(i)
let bigF = BigInt.fromFloat(f)

is compiled to

var bigI = BigInt(1);

var bigF = BigInt(1.3);

var i = 1;

var f = 1.3;

Problem: in JS, BigInt(x) is valid only if x is an integer, not a float, so running var bigF = BigInt(1.3) throws an error

@remitbri
Copy link
Author

remitbri commented Oct 7, 2024

Potential fix:
redefining in Core__BigInt.res to

let fromFloat = t => t->Core__Int.fromFloat->fromInt

with some documentation in the interface file, maybe adapting what's already available for Core__Int.fromFloat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants