Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models do not perform well for full range of outcomes #42

Open
rikhuijzer opened this issue Jul 27, 2023 · 1 comment
Open

Models do not perform well for full range of outcomes #42

rikhuijzer opened this issue Jul 27, 2023 · 1 comment

Comments

@rikhuijzer
Copy link
Owner

It looks like there is a sort of balancing issue. The following is an image on SIRUS 1.1.2, but the same occurs on 1.3.0:

auc plots

It looks like the model optimizes for one area and not for another. I still suspect this is an issue with the choice of weights. Something is causing the weights to be not chosen properly which then causes sub-optimal classification predictions and poor regression predictions.
@rikhuijzer
Copy link
Owner Author

To solve this, I should probably set lambda because the weight logic is very sensitive to the choice of lambda.

@rikhuijzer rikhuijzer mentioned this issue Nov 28, 2023
Merged
rikhuijzer added a commit that referenced this issue Nov 28, 2023
@rikhuijzer
Another shot at fixing regression (#71)
9e90683 
Another shot at #27 and
#42.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rikhuijzer