Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing incorrect animationName #259

Open
Bayramito opened this issue Jul 16, 2024 · 2 comments
Open

Passing incorrect animationName #259

Bayramito opened this issue Jul 16, 2024 · 2 comments

Comments

@Bayramito
Copy link

Bayramito commented Jul 16, 2024

Hi,

This is a very common issue, i dunno if i'm the only one who gets it but,

once you pass the animationName incorrectly to the ref methods, the app is crashing.

In the .riv files sometimes the animation names can be uppercase or camel case, so we need some sort of fix to handle this situation. Like checking or converting both requested and existing animations names to lowercase.

@CoopCodes
Copy link

Yeah I get the same, if I get the state machine name, or the animation name or input name wrong it just crashes without any error. Would be good if it just didn't do anything, or just gave a warning.

@guval-gh
Copy link

guval-gh commented Nov 6, 2024

Same here.

And even if the error is normally handled like in this example: https://github.com/rive-app/rive-react-native/blob/ba12e7a5117a4d948af66f10dcd9d2ff304d2204/example/src/ErrorHandledManually.tsx

The url is IncorrectRiveFileUrl or if resourceName is MalformedFile, app instant crashes on iOS for me (didn't test on Android).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants