Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3.0 instant launch crash React Native 0.74.5 #262

Closed
hamdij0maa opened this issue Aug 26, 2024 · 19 comments
Closed

7.3.0 instant launch crash React Native 0.74.5 #262

hamdij0maa opened this issue Aug 26, 2024 · 19 comments

Comments

@hamdij0maa
Copy link

Install rive-react-native 7.3.0
instant crash android on launch.

@HayesGordon
Copy link
Contributor

Hi @hamdij0maa can you share

  • the .riv file you're using
  • the code
  • the crash log

@mlazari
Copy link

mlazari commented Sep 2, 2024

I see the same issue (crash on app start) but only on iOS in an expo project.

    "expo": "~51.0.31",
    "react-native": "0.74.5",
    "rive-react-native": "^7.3.0",

It crashes even if I remove all usages of rive-react-native in the code so I don't think it's related to a specific animation file or code.
Screenshot 2024-09-02 at 15 37 05

Downgrading to 7.2.0 fixes the crash.

I tried the same version 7.3.0 of rive-react-native in a bare React Native project with the same react-native version (0.74.5) and it works well there.

@bitcrumb
Copy link

bitcrumb commented Sep 3, 2024

Same issue as @mlazari

@mlazari
Copy link

mlazari commented Sep 3, 2024

I guess my issue is the same as #261

@bernardo-amaral-movile
Copy link

I'm having the same issue here after upgrading to React Native 0.74.5. However, my Rive version is 6.2.3.
Crash Free users on the version with React Native 0.74.5 dropped to 64% (from 98%+).

I can see a SIGABRT crash on libc.so and the logs also show librive-android.so on the stack trace. We need this fixed ASAP. Could you please help us? Is there a Rive version that has been tested with React Native 0.74.5?

image

@lancesnider
Copy link
Contributor

Hey all. 👋 I've just started working on updating the repo to support the latest couple of versions of RN. Step one is getting all of our packages upgraded to more recent versions while still using RN 0.72.x. This'll make it easier to do the next couple of upgrades. If anyone wants to give it a test on a 0.72.x project, that'd be super helpful: #267

@PierreCapo
Copy link

PierreCapo commented Nov 18, 2024

@lancesnider @HayesGordon sorry in advance for pinging you, but do you have any visibility on when this is going to be fixed?
This issue has been opened for 3 months and makes Rive completely unusable.
It starts to get annoying as customers, as we paid to get some Rive assets that we can not use in our apps...

For tracking purpose, here is the other issue opened:
#268

@HayesGordon
Copy link
Contributor

Hi @PierreCapo, does the latest version of Rive React Native not solve this for you?

@Maniae
Copy link

Maniae commented Nov 18, 2024

@HayesGordon Still having the same issue with rive-react-native 8.1.0
Capture d’écran 2024-11-18 à 14 56 58

Using s.dependency "RiveRuntime", "6.3.3" according to podspec

Related to this issue on rive-ios: rive-app/rive-ios#345

@leemhenson
Copy link

leemhenson commented Nov 22, 2024

I'm cheating by not waiting for the 8.2 release, and I'm instead using:

"rive-react-native": "github:rive-app/rive-react-native#pull/274/head",

in my package.json . It's compiling against RN 0.76/Expo 52. 👍

Now there's just the small matter of making Rive compatible with the new architecture. 🙏

Damn - I don't know what happened but now it fails again on the yoga symbols. Perhaps I had an older version cached somewhere when I thought it was working earlier. Sigh.

@casualWaist
Copy link

also stuck on this issue. I have a test working with rive-react-native 8.1.0 and RN 0.76.1, but in the app with RN 0.74.5 I haven't gotten any version of rive-react-native to work. Also holding us up. Have seen some comments suggesting Firebase may be part of the problem and we are using Firebase in our project while the test project does not.

@leemhenson
Copy link

we are using Firebase in our project

we are also using https://github.com/invertase/react-native-firebase

@PierreCapo
Copy link

Same, most likely an issue related with the static linking for frameworks enforced by React-Native Firebase

@rlods
Copy link

rlods commented Nov 27, 2024

Any updates on that topic?

Crash at launch still happens when trying to use [email protected] released in November

  • Issue appeared from 7.3.0
  • No pb when using 7.2.0
image

context: React-Native 0.76 & Expo 52

cc @HayesGordon would you know if someone from Rive is aware and following the issue?

Thanks in advance 🙏

@uglyghosty
Copy link

Still crashing on 0.76, no expo, also using firebase

@evelant
Copy link

evelant commented Dec 3, 2024

8.2.0 also crashes, exactly the same. @HayesGordon

Thread 9 Crashed::  Dispatch queue: com.facebook.react.ShadowQueue
0   ???                           	          0x104100 ???
1   TaskHero.debug.dylib          	       0x112961134 -[RCTShadowView layoutWithMinimumSize:maximumSize:layoutDirection:layoutContext:] + 176 (RCTShadowView.m:268)
2   TaskHero.debug.dylib          	       0x1129515f4 -[RCTRootShadowView layoutWithAffectedShadowViews:] + 264 (RCTRootShadowView.m:35)
3   TaskHero.debug.dylib          	       0x112974b24 -[RCTUIManager uiBlockWithLayoutUpdateForRootView:] + 344 (RCTUIManager.m:549)
4   TaskHero.debug.dylib          	       0x11297a83c -[RCTUIManager _layoutAndMount] + 336 (RCTUIManager.m:1126)
5   TaskHero.debug.dylib          	       0x11297a6e0 -[RCTUIManager batchDidComplete] + 32 (RCTUIManager.m:1109)
6   TaskHero.debug.dylib          	       0x1128c4ac8 __32-[RCTCxxBridge batchDidComplete]_block_invoke + 56 (RCTCxxBridge.mm:1540)
7   libdispatch.dylib             	       0x1801774ec _dispatch_call_block_and_release + 24
8   libdispatch.dylib             	       0x180178de0 _dispatch_client_callout + 16
9   libdispatch.dylib             	       0x180180f60 _dispatch_lane_serial_drain + 956
10  libdispatch.dylib             	       0x180181a98 _dispatch_lane_invoke + 388
11  libdispatch.dylib             	       0x18018cf44 _dispatch_root_queue_drain_deferred_wlh + 276
12  libdispatch.dylib             	       0x18018c5a0 _dispatch_workloop_worker_thread + 440
13  libsystem_pthread.dylib       	       0x104487b74 _pthread_wqthread + 284
14  libsystem_pthread.dylib       	       0x104486934 start_wqthread + 8

@PierreCapo
Copy link

Fixed in the last commit e9fa101 🎉 Working on my side

@lancesnider
Copy link
Contributor

Yep, this one should be working for all of you now with 8.3.0. Please let me know if you run into any issues with this. Sorry it took so long!

@mlazari
Copy link

mlazari commented Dec 7, 2024

8.3.0 is working on my side too 🎉 Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

15 participants