Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test registerNativeModule #54

Open
grabbou opened this issue Mar 30, 2016 · 4 comments
Open

Test registerNativeModule #54

grabbou opened this issue Mar 30, 2016 · 4 comments

Comments

@grabbou
Copy link
Member

grabbou commented Mar 30, 2016

So far we only covered link and unlink general interface. We have to make sure underlying functions are all green as well on both platforms to make sure glitches like the current one do not happen again in the future.

I am going to write some of them for iOS tomorrow soonish.

@Kureev
Copy link
Member

Kureev commented Apr 25, 2016

image

@grabbou
Copy link
Member Author

grabbou commented Apr 25, 2016

Is that adding anything productive to our discussion @Kureev ? The tests were being constantly improved, but I wasn't just referencing the issue. The last sentence was just note to self.

@Kureev
Copy link
Member

Kureev commented Apr 25, 2016

Nope, don't take it seriously. 😃

@grabbou
Copy link
Member Author

grabbou commented May 2, 2016

Edit: I am still not sure how to best structure the suite. Running a case with 12 spies is not appealing. Now that we have removed almost every conditional from these methods (on iOS we only check if libraries folder doesn't exist and create it transparently), I am not really sure if we need to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants