Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] #3

Open
gitfve opened this issue Sep 20, 2019 · 2 comments
Open

[Suggestion] #3

gitfve opened this issue Sep 20, 2019 · 2 comments

Comments

@gitfve
Copy link

gitfve commented Sep 20, 2019

-Hints-

  • In the setup, set filter to MAX31856_NOISE_FILTER_50HZ or ..._60HZ you newer use the filter?
  • Updating display every 100ms, why? It is real time heavy...
  • Reading sensor every 1000ms? Must be more often for to get PID more accurate
  • Code clean up, and use some function and not so many Global vars:-(

  • Option to select more profiles 1..10
  • Option to select the 50/60HZ filter.
  • Option to set some PID values.
@rocketscream
Copy link
Owner

rocketscream commented Sep 23, 2019

In the setup, set filter to MAX31856_NOISE_FILTER_50HZ or ..._60HZ you newer use the filter?

This is good suggestion. I'll check whether the Adafruit MAX31856 library has this enabled. If not, I will do a pull first.

Updating display every 100ms, why? It is real time heavy...
It was initially set at a lower rate during development stage. But, as it is a human interface, whenever a human presses a button or an error occurs, user expect instant visual feedback on the display. Refreshing it slower will let the user think the button presses are not working and other visual feedback issue.

Reading sensor every 1000ms? Must be more often for to get PID more accurate

Yes, we do not need to sample that fast. In previous version it was even sampled once per second. But, for simplicity with the UI refresh rate, it was set same as the display refresh rate. It doesn't do any harm sampling any faster too.

Code clean up, and use some function and not so many Global vars:-(

Please suggest which variable that can be further improved into a local variable. And do a pull request.

Option to select more profiles 1..10
Option to select the 50/60HZ filter.
Option to set some PID values.

Not sure whether any more profiles is of any use as most user just want to reflow either a leaded or lead free. The filter option is good and as explained above. Tweaking the PID values is great but it will open up a whole bigger cans of issues later (user might tweak it wrongly, oven not responding as expected, profile goes off, etc). You can always use the default values and tweak it from there.

One of the objective of the controller is to be simple and does what it needs to do: reflow.

@Teknost
Copy link

Teknost commented Apr 15, 2020

Additional profiles for 3D printer filament drying would be awesome. i.e. straight baking for a few hours at 40C or 80C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants