Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlights #428

Closed
ttytm opened this issue Apr 3, 2023 · 3 comments · Fixed by #485
Closed

Update highlights #428

ttytm opened this issue Apr 3, 2023 · 3 comments · Fixed by #485
Labels
request New feature or request
Milestone

Comments

@ttytm
Copy link
Contributor

ttytm commented Apr 3, 2023

If that fits to the repo, the highlights groups could be updated / extended.

Highlights for diagnostic could link to the nvim highlights groups DiagnosticSignWarn, DiagnosticSignError etc.. Those are also the ones that are usually manipulated by themes. It might make this part of barbar a little more cross theme compatible out of the box.

Groups that could be added related to 'Buffer' .. activity .. 'Sign' are 'Buffer' .. activity .. 'SignLeft' and 'Buffer' .. activity .. 'SignRight'. This is something for the tinkerers. For me personally it would allow me to keep a style I made for my bufferlines that emulates a shadow thrown from active buffers on other buffers / the tabline. I called this style "slim shady" back then lol.

Screenshot_20230403_135706


edit: I see that the first suggestion with linking the groups would probably interfere with the background. So i'd like to update the suggestion to deriving the fg color for those groups from the mentioned nvim hl groups.

@Iron-E Iron-E added the request New feature or request label Apr 3, 2023
@Iron-E
Copy link
Collaborator

Iron-E commented Apr 5, 2023

Related: #199

@Iron-E
Copy link
Collaborator

Iron-E commented May 8, 2023

@tobealive does #485 help?

@ttytm
Copy link
Contributor Author

ttytm commented May 10, 2023

awesome, thanks @Iron-E !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants