Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bufferline folder #535

Closed
litoj opened this issue Nov 21, 2023 · 4 comments
Closed

Remove bufferline folder #535

litoj opened this issue Nov 21, 2023 · 4 comments
Assignees
Labels
refactor Misc. change in an existing component of barbar.nvim
Milestone

Comments

@litoj
Copy link

litoj commented Nov 21, 2023

I think it is unnecessary to have a copy of an entire plugin just beacause of a rename. In case you really want to avoid forcing users to use the actual plugin name you could use a loop for all bufferline.xxx and put a hook in package.preload['bufferline.xxx'] that would return the corresponding barbar.xxx module.

@Iron-E
Copy link
Collaborator

Iron-E commented Nov 21, 2023

I'm not immediately familiar with that solution, though I can certainly look into it (since it sounds much more clean than what we're doing).

A PR would be welcome if you are open to it and get around to it faster!

@Iron-E Iron-E added the refactor Misc. change in an existing component of barbar.nvim label Nov 21, 2023
@litoj
Copy link
Author

litoj commented Nov 22, 2023

I opened up a PR that keeps it working exactly the way it was now.

@Iron-E Iron-E self-assigned this Nov 25, 2023
@Iron-E Iron-E added this to the 1.8 milestone Nov 25, 2023
@romgrk romgrk mentioned this issue Nov 28, 2023
7 tasks
@romgrk
Copy link
Owner

romgrk commented Nov 28, 2023

I've added this point to the 2.0 issue, at some point we should have users migrate to require'barbar'.

@Iron-E Iron-E modified the milestones: 1.8, 2.0 Nov 28, 2023
@Iron-E
Copy link
Collaborator

Iron-E commented Jan 13, 2024

Will close this as it's being tracked in #394.

@Iron-E Iron-E closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Misc. change in an existing component of barbar.nvim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants