Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Get osmconf.ini in synch with GDAL #261

Open
agila5 opened this issue Aug 17, 2022 · 3 comments · May be fixed by #304
Open

[FEATURE] Get osmconf.ini in synch with GDAL #261

agila5 opened this issue Aug 17, 2022 · 3 comments · May be fixed by #304
Assignees
Milestone

Comments

@agila5
Copy link
Collaborator

agila5 commented Aug 17, 2022

As the title says.

@agila5 agila5 self-assigned this Aug 17, 2022
@agila5
Copy link
Collaborator Author

agila5 commented Aug 17, 2022

An even better approach would be to directly derive the osmconfig file from sf repo. Need to think about it.

@agila5 agila5 modified the milestones: 0.5.0, 0.6.0 Mar 7, 2023
@agila5 agila5 changed the title [FEATURE] Update osmconf.ini and all relevant parts in the package [FEATURE] Get osmconf.ini in synch with sf May 22, 2024
@agila5
Copy link
Collaborator Author

agila5 commented May 22, 2024

I will also need to update several parts of the package, for example:

get_id_layer = function(layer) {
default_id = list(
points = 33L,
lines = 53L,
multipolygons = 85L,
multilinestrings = 103L,
other_relations = 121L
)
default_id[[layer]]
}
get_fields_default = function(layer) {
def_layers = list(
points = c(
"name",
"barrier",
"highway",
"ref",
"address",
"is_in",
"place",
"man_made"
),
lines = c(
"name",
"highway",
"waterway",
"aerialway",
"barrier",
"man_made"
),
multipolygons = c(
"name",
"type",
"aeroway",
"amenity",
"admin_level",
"barrier",
"boundary",
"building",
"craft",
"geological",
"historic",
"land_area",
"landuse",
"leisure",
"man_made",
"military",
"natural",
"office",
"place",
"shop",
"sport",
"tourism"
),
multilinestrings = c("name", "type"),
other_relations = c("name", "type")
)
def_layers[[layer]]
}

agila5 added a commit that referenced this issue Nov 12, 2024
@agila5 agila5 changed the title [FEATURE] Get osmconf.ini in synch with sf [FEATURE] Get osmconf.ini in synch with GDAL Nov 12, 2024
@agila5
Copy link
Collaborator Author

agila5 commented Nov 12, 2024

See @r-spatial/discuss#66 for a solution!

agila5 added a commit that referenced this issue Nov 12, 2024
@agila5 agila5 linked a pull request Nov 12, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant