Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MikePurvis fix for recent CMake support #1

Closed
mikaelarguedas opened this issue Nov 14, 2024 · 4 comments
Closed

Use MikePurvis fix for recent CMake support #1

mikaelarguedas opened this issue Nov 14, 2024 · 4 comments

Comments

@mikaelarguedas
Copy link

For some reason I didnt succeed to open a PR towards this fork.

To reduce the amount of deprecation warnings while building ROS 1 packages on recent platforms it would be great to integrate this PR ros#1195 from @mikepurvis into the ros-o version.

WDYT ?

@mikaelarguedas
Copy link
Author

@rhaschke @v4hn what do you think about this ? Is this considered too cosmetic (as catkin can run without errors without it) to be included in the ros-o version of catkin ?

@rhaschke
Copy link

Thanks for pinging me. This looks reasonable at first sight, but I will have a deeper look later.

@rhaschke
Copy link

Merged: 5a4540c

@v4hn
Copy link
Member

v4hn commented Nov 22, 2024

Also merged in Debian ros-catkin 0.8.10-17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants