Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: rename .tito/tito.props to .tito/props.ini #506

Open
Malix-Labs opened this issue Oct 13, 2024 · 5 comments
Open

Proposal: rename .tito/tito.props to .tito/props.ini #506

Malix-Labs opened this issue Oct 13, 2024 · 5 comments

Comments

@Malix-Labs
Copy link

Malix-Labs commented Oct 13, 2024

Subject

.tito/tito.props

Problem

  1. File Extension : It seems to have an ini file format but has a .props file extension (doesn't get highlighted nor linted properly)
  2. Redundancy : duplicated "tito"

Solution

Rename it to .tito/props.ini

Workaround

Point 1 only

VSCode

Append these lines to your settings.json :

"files.associations": {
	"tito.props": "ini"
}
@FrostyX
Copy link
Member

FrostyX commented Oct 14, 2024

Hello @Malix-Labs,
thank you for the RFE.

I completely agree with your reasoning and that the .tito/props.ini would be better.
We also have .tito/releasers.conf so .tito/props.conf would be more consistent even though it sounds ridiculous. Personally, I would land at .tito/tito.conf even if there is the mentioned redundancy.

But I am not sure whether it is something worth breaking the backward compatibility for. IMHO it isn't. There are blog posts about Tito that would get outdated, upstream repos would have to migrate to the new config name, etc.

The manual page man tito.props says

Project settings can be stored in files:
GITROOT/.tito/tito.props
GITROOT/SOME/PACKAGE/tito.props

so maybe it will be possible to add a third file to this and let tito init create a symlink from tito.props to the new file to preserve backward compatibility and slowly deprecate the old one. But that again sounds like too much hassle for too little benefit.

What are your thoughts?

@Malix-Labs
Copy link
Author

Hello @FrostyX, thanks for your time reading and replying to my issue !

But I am not sure whether it is something worth breaking the backward compatibility for. IMHO it isn't. There are blog posts about Tito that would get outdated, upstream repos would have to migrate to the new config name, etc.

Wouldn't it be possible to make both file work (with a priority order ofc), and to make tito init create the new file names instead?

I think this is the best of both world, and what has worked for most of the project I contribute too, such as VSCode and Vite

so maybe it will be possible to add a third file to this and let tito init create a symlink from tito.props to the new file to preserve backward compatibility and slowly deprecate the old one. But that again sounds like too much hassle for too little benefit.

This is also possible indeed but would perhaps be more work ?
Technically, it might be better indeed

@FrostyX FrostyX moved this to Needs triage in CPT Kanban Oct 14, 2024
@FrostyX
Copy link
Member

FrostyX commented Oct 25, 2024

Wouldn't it be possible to make both file work (with a priority order ofc), and to make tito init create the new file names instead?

We discussed this on a team meeting, and it should be possible and nobody has anything against it. But I don't have any time to work on this, so you would have to submit a PR with the change.

The only problem with the solution you are proposing is that many documents and blog posts mention .tito/tito.props and they would unnecessarily become outdated once tito init starts creating the new file. So I think tito init should also create .tito/tito.props which would be a symlink to the new file.

@FrostyX FrostyX moved this from Needs triage to Someday in future in CPT Kanban Oct 25, 2024
@Malix-Labs
Copy link
Author

you would have to submit a PR with the change

I unfortunately also have no time for this atm, but that's not an important nor urgent change

If I ever end up using tito very much, I would consider working on this, but that's very improbable

@Malix-Labs Malix-Labs closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@Malix-Labs Malix-Labs reopened this Oct 25, 2024
@github-project-automation github-project-automation bot moved this from Someday in future to Needs triage in CPT Kanban Oct 25, 2024
@Malix-Labs
Copy link
Author

Sorry, I missclicked on closed as not planned

@nikromen nikromen moved this from Needs triage to Someday in future in CPT Kanban Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants