undeclared identifier

[petemoore]

Hi folks!

Clearly I'm doing something wrong, but I can't work out what. Any tips welcome, thanks! :-)

The script I'm running:

pmoore@Peters-MacBook-Pro-2:~/tmp $ cat test.sh 
#!/usr/bin/env bash

set -eu
set -o pipefail
rm -rf circle
git clone [email protected]:rsta2/circle.git
cd circle
GIT_COMMIT_SHA="$(git rev-parse HEAD)"

echo
echo "Circle git commit: ${GIT_COMMIT_SHA}"
echo

cat << EOF > Config.mk
AARCH = 64
RASPPI = 4
PREFIX64 = aarch64-none-elf-
EOF

./makeall
cd sample/08-usbkeyboard/
make
pmoore@Peters-MacBook-Pro-2:~/tmp $

And then I run it and hit a compile error:

pmoore@Peters-MacBook-Pro-2:~/tmp $ ./test.sh 
Cloning into 'circle'...
remote: Enumerating objects: 15781, done.
remote: Counting objects: 100% (4179/4179), done.
remote: Compressing objects: 100% (1057/1057), done.
remote: Total 15781 (delta 3288), reused 3720 (delta 3119), pack-reused 11602 (from 1)
Receiving objects: 100% (15781/15781), 7.37 MiB | 7.48 MiB/s, done.
Resolving deltas: 100% (11097/11097), done.

Circle git commit: c243194670720c8a13e6a553654b6d26ec7845a0

  TOOL  cflashy
cflashy.c:98:12: error: use of undeclared identifier 'B460800'
   98 |                 {460800,        B460800},
      |                                 ^
cflashy.c:99:12: error: use of undeclared identifier 'B500000'
   99 |                 {500000,        B500000},
      |                                 ^
cflashy.c:100:12: error: use of undeclared identifier 'B576000'
  100 |                 {576000,        B576000},
      |                                 ^
cflashy.c:101:12: error: use of undeclared identifier 'B921600'
  101 |                 {921600,        B921600},
      |                                 ^
cflashy.c:102:13: error: use of undeclared identifier 'B1000000'
  102 |                 {1000000,       B1000000},
      |                                 ^
cflashy.c:103:13: error: use of undeclared identifier 'B1152000'
  103 |                 {1152000,       B1152000},
      |                                 ^
cflashy.c:104:13: error: use of undeclared identifier 'B1500000'
  104 |                 {1500000,       B1500000},
      |                                 ^
cflashy.c:105:13: error: use of undeclared identifier 'B2000000'
  105 |                 {2000000,       B2000000},
      |                                 ^
cflashy.c:106:13: error: use of undeclared identifier 'B2500000'
  106 |                 {2500000,       B2500000},
      |                                 ^
cflashy.c:107:13: error: use of undeclared identifier 'B3000000'
  107 |                 {3000000,       B3000000},
      |                                 ^
cflashy.c:108:13: error: use of undeclared identifier 'B3500000'
  108 |                 {3500000,       B3500000},
      |                                 ^
cflashy.c:109:13: error: use of undeclared identifier 'B4000000'
  109 |                 {4000000,       B4000000},
      |                                 ^
12 errors generated.
make: *** [cflashy] Error 1
pmoore@Peters-MacBook-Pro-2:~/tmp $ 

Indeed looking at source code, I can't find identifier declarations, e.g.:

pmoore@Peters-MacBook-Pro-2:~/tmp $ git -C circle grep B460800
tools/cflashy.c:                {460800,        B460800},
pmoore@Peters-MacBook-Pro-2:~/tmp $ 

But I'm no C++ expert, so maybe this is expected. It looks like this code was introduced in 47d51a0 over 3 months ago, so it must be something I'm doing, because somebody would have noticed since then I'm sure.

Any tips welcome, thanks!
Pete

[rsta2]

This is a problem with tools/cflashy.c, the new serial bootloader version from Circle, written in C, which obviously cannot be build on MacOS. I do not have a Mac and wasn't able to test this. This patch should help to disable cFlashy on MacOS, so that you can build the other libraries and files:

diff --git a/tools/Makefile b/tools/Makefile
index 26286b4..d2e4407 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -2,7 +2,7 @@
 # Makefile
 #
 
-ifneq ($(OS),Windows_NT)
+ifeq ($(OSTYPE),linux)
 
 all: cflashy converttool
 
@@ -26,7 +26,7 @@ converttool.win: converttool.c
        x86_64-w64-mingw32-gcc -o converttool.win converttool.c
        chmod -x converttool.win
 
-else
+else ifeq ($(OS),Windows_NT)
 
 all: cflashy.exe converttool.exe
 
@@ -42,4 +42,14 @@ clean:
        @echo "  CLEAN " `pwd`
        @rm -rf cflashy.exe converttool.exe
 
+else
+
+converttool: converttool.c
+       @echo "  TOOL  $@"
+       @gcc -o converttool converttool.c
+
+clean:
+       @echo "  CLEAN " `pwd`
+       @rm -rf converttool
+
 endif

[petemoore]

Many thanks Rene, this fixed it! Really appreciated!
By the way, do you ever give presentations or attend particular meetups? I think we're both in Germany, if there is anything going on where you are giving talks etc, I would be interested to attend!

[petemoore]

I've put up an alternative fix in #501 which just removes the unsupported serial baud rates on macOS. Thanks!

[rsta2]

You are welcome. Thanks for asking, but I never attended meetups. I prefer staying in background. ;)

Thanks for the alternative fix. That's a better solution.