Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggregate reports based on the configured interval before sending to reporting #5326

Open
wants to merge 8 commits into
base: feat.reports-bactching
Choose a base branch
from

Conversation

itsmihir
Copy link
Contributor

@itsmihir itsmihir commented Nov 27, 2024

Description

Currently, the Rudder Server aggregates reports every minute and then flushes them to the Reporting Service. We want to make the aggregation interval configurable, allowing reports to be aggregated over a specified time period, such as 2 minutes instead of the default 1 minute.

Linear Ticket

https://linear.app/rudderstack/issue/OBS-415/support-aggregation-time-as-a-configuration-on-rudder-server-ability

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@itsmihir itsmihir marked this pull request as draft November 27, 2024 11:46
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.59%. Comparing base (b79444f) to head (2b27e81).
Report is 19 commits behind head on feat.reports-bactching.

Files with missing lines Patch % Lines
enterprise/reporting/reporting.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feat.reports-bactching    #5326      +/-   ##
==========================================================
+ Coverage                   73.21%   73.59%   +0.37%     
==========================================================
  Files                         423      424       +1     
  Lines                       59908    59952      +44     
==========================================================
+ Hits                        43863    44119     +256     
+ Misses                      13584    13364     -220     
- Partials                     2461     2469       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsmihir itsmihir marked this pull request as ready for review November 27, 2024 12:51
@itsmihir itsmihir changed the base branch from master to feat.reports-bactching November 28, 2024 06:01
…s/rudder-server into feature/obs-415-support-aggregation-time-as-a-configuration-on-rudder-server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant