Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't the CI use svd2rust-regress? #689

Open
YuhanLiin opened this issue Oct 29, 2022 · 3 comments
Open

Why doesn't the CI use svd2rust-regress? #689

YuhanLiin opened this issue Oct 29, 2022 · 3 comments

Comments

@YuhanLiin
Copy link
Contributor

The CI script seems to do the exact same thing as svd2rust-regress, so I'm wondering why they're separated.

@Emilgardis
Copy link
Member

Emilgardis commented Oct 30, 2022

no real reason but that we haven't gotten to it :)

Some previous discussions on this

#542 (comment)

I've previously also mentioned the possibility to use something like bors try --regress to catch changes in prs and print them as comments, with the new github cli I think we can do this easily and improve the experience.

@burrbull
Copy link
Member

burrbull commented Jan 2, 2024

cc @Emilgardis should CI be replaced with svd2rust-regress test?

@Emilgardis
Copy link
Member

I think it could and probably should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants