Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move must_use from methods to generic type #870

Merged
merged 1 commit into from
Oct 18, 2024
Merged

move must_use from methods to generic type #870

merged 1 commit into from
Oct 18, 2024

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Oct 16, 2024 •
edited
Loading

need to test first if it works as expected

@burrbull burrbull requested a review from a team as a code owner October 16, 2024 17:16
@burrbull burrbull marked this pull request as draft October 17, 2024 16:58
@burrbull burrbull marked this pull request as ready for review October 17, 2024 17:04
@burrbull
Copy link
Member Author

cc @Emilgardis

Emilgardis
Emilgardis approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@burrbull burrbull added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 65fb8e0 Oct 18, 2024
46 checks passed
@burrbull burrbull deleted the must branch October 18, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis