Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading release artifacts fails too often #11056

Closed
lnicola opened this issue Dec 19, 2021 · 12 comments
Closed

Uploading release artifacts fails too often #11056

lnicola opened this issue Dec 19, 2021 · 12 comments
Labels
A-infra CI and workflow issues S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@lnicola
Copy link
Member

lnicola commented Dec 19, 2021

It failed again last night, two times in a row. These are ECONNRESETs during the upload.

We're using some older code, but I fail to see what could be wrong there.
@lnicola lnicola added S-unactionable Issue requires feedback, design decisions or is blocked on other work A-infra CI and workflow issues labels Dec 19, 2021
@lnicola lnicola mentioned this issue Dec 19, 2021
Closed
@lnicola
Copy link
Member Author

lnicola commented Dec 19, 2021

In a commit linked in actions/upload-release-asset#69, the solution was to use the gh release command.

@lnicola
Copy link
Member Author

lnicola commented Dec 20, 2021

I started community/community#9121 about this.

@ishanjain28

This comment has been minimized.

Sign in to view
@lnicola

This comment has been minimized.

Sign in to view
@ishanjain28

This comment has been minimized.

Sign in to view
@lnicola

This comment has been minimized.

Sign in to view
@ishanjain28

This comment has been minimized.

Sign in to view
@lnicola lnicola mentioned this issue Dec 22, 2021
Merged
bors bot added a commit that referenced this issue Dec 22, 2021
@bors @lnicola
Merge #11103
4ea1f58 
11103: internal: Improve `github-release` action r=lnicola a=lnicola

Upgrade ``@actions/github`` to get `listReleaseAssets` and retry individual uploads in addition to the whole thing.

Also disables `ci`, `metrics` and `rustdoc` on forks to save some CPU time.

CC #11056

Co-authored-by: Laurențiu Nicola <[email protected]>
@villem

This comment has been minimized.

Sign in to view
@lnicola

This comment has been minimized.

Sign in to view
@villem
Copy link

villem commented Dec 28, 2021

Thanks! Manually installation worked. I understood that this only an issue with "released" version of RA, not with nightlies.

@lnicola
Copy link
Member Author

lnicola commented Dec 28, 2021

Your original problem was strictly related to nightly channel updates: the old nightlies didn't know which VSIX to download in order to update. We could have implemented that, but we would have needed to support both for a time because not everyone updates daily.

The Open VSX problem is probably affecting every installation. I don't know how the extension gets published there, but it's likely that the nightlies from the Code Marketplace end up on Open VSX as stable version. Even the Code Marketplace is pretty buggy and can't differentiate between stable and nightly. These are all nightlies:

image

The "installs old version" problem with the official marketplace probably affects only stable users. If you were using nightly before, you can try to opt in to pre-release versions and see what happens.

@lnicola lnicola mentioned this issue Dec 28, 2021
Merged
bors bot added a commit that referenced this issue Dec 28, 2021
@bors @lnicola
Merge #11127
05f7924 
11127: internal: Set a timeout on the Octokit client r=lnicola a=lnicola

CC #11056

Co-authored-by: Laurențiu Nicola <[email protected]>
@lnicola
Copy link
Member Author

lnicola commented Dec 28, 2021

Between #11103 and #11127, we've probably done all we could on our side. GitHub is still pretty unreliable, though.

@lnicola lnicola closed this as completed Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infra CI and workflow issues S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@villem @lnicola @ishanjain28