Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutex in X11 backend locked twice without unlock #347

Closed
bvssvni opened this issue Nov 11, 2017 · 3 comments
Closed

Mutex in X11 backend locked twice without unlock #347

bvssvni opened this issue Nov 11, 2017 · 3 comments
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched D - hard Likely harder than most tasks here DS - x11 H - help wanted Someone please save us P - low Nice to have

Comments

@bvssvni
Copy link
Contributor

bvssvni commented Nov 11, 2017

See PistonDevelopers/piston_window#215 (comment)

@bvssvni looks to be happening in the winit's X11 window destructor. PoisonError is for mutex being locked twice without unlocking. I suggest filing an issue to winit.

cc @kvark

For backtrace, see PistonDevelopers/piston_window#215 (comment)
@bvssvni bvssvni mentioned this issue Nov 11, 2017
Closed
@tomaka tomaka added DS - x11 B - bug Dang, that shouldn't have happened labels Nov 11, 2017
@Ralith
Copy link
Contributor

Ralith commented Nov 12, 2017

The mutex may be unnecessary as of #191.

@francesca64 francesca64 self-assigned this Dec 31, 2017
@malikolivier malikolivier mentioned this issue Mar 12, 2018
Open
@francesca64 francesca64 added H - help wanted Someone please save us C - needs investigation Issue must be confirmed and researched D - hard Likely harder than most tasks here P - low Nice to have labels May 6, 2018
@francesca64 francesca64 removed their assignment May 6, 2018
@francesca64
Copy link
Member

The mutex problems don't happen anymore, though now it segfaults in XCloseIM, which is quite unusual (since the input method shouldn't be closing). Fixing that is trivial, but while that allows multi-window Piston applications to run, they won't have working IME

IME works fine in single-window Piston apps, and fine in non-Piston multi-window apps (even multi-threaded ones). Someone more versed in Piston's internals would have to help out on investigating. This is a very unusual issue, and I imagine it comes down to the unsoundness of Xlib in some way or another (the XIM client is especially bad). If Piston's multi-window code is using multi-threading somewhere, that's a likely suspect.

@francesca64 francesca64 mentioned this issue Jun 6, 2018
Closed
@maroider maroider mentioned this issue Dec 20, 2020
Closed
tmfink pushed a commit to tmfink/winit that referenced this issue Jan 5, 2022
@bors-servo
Auto merge of rust-windowing#347 - as-cii:metal-manifest, r=pcwalton
1b63996 
Add missing Metal shader to resources/MANIFEST

This fixes an issue that caused `pathfinder_metal` to panic when [attempting to load shaders](https://github.com/servo/pathfinder/blob/0f3500921596bdb2924d7bd62c4f983afc9332ec/metal/src/lib.rs#L854) using the embedded resource loader.

/cc: @nathansobo
@kchibisov
Copy link
Member

I don't think this is relevant anymore.

madsmtm pushed a commit to madsmtm/winit that referenced this issue Jun 11, 2022
@lucasfernog
refactor: fix and enhance the about menu on Linux (rust-windowing#347)
84c677f 
* refactor: fix and enhance the about menu on Linux

* simplify

* apply code review suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B - bug Dang, that shouldn't have happened C - needs investigation Issue must be confirmed and researched D - hard Likely harder than most tasks here DS - x11 H - help wanted Someone please save us P - low Nice to have
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Ralith @tomaka @bvssvni @francesca64 @goddessfreya @kchibisov