-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mount): rename fields for clarity, add user options for mount #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsan <[email protected]>
simonsan
added
A-commands
Area: Related to commands in `rustic`
C-refactor
Category: Refactoring of already existing code
A-config
Area: Related to the config file functionality and format
labels
Nov 11, 2024
simonsan
changed the title
refactor(mount): rename fields for clarity
refactor(mount): rename fields for clarity, add user options for mount
Nov 12, 2024
simonsan
force-pushed
the
refactor/mount-cmd
branch
from
November 12, 2024 02:00
208dc04
to
4c326f1
Compare
Signed-off-by: simonsan <[email protected]>
simonsan
force-pushed
the
refactor/mount-cmd
branch
from
November 12, 2024 02:15
ff40ea7
to
4eaee90
Compare
Signed-off-by: simonsan <[email protected]>
aawsome
reviewed
Nov 19, 2024
…ons handling Signed-off-by: simonsan <[email protected]>
aawsome
reviewed
Nov 19, 2024
…roved config handling Signed-off-by: simonsan <[email protected]>
Signed-off-by: simonsan <[email protected]>
aawsome
reviewed
Nov 23, 2024
Signed-off-by: simonsan <[email protected]>
Signed-off-by: simonsan <[email protected]>
Signed-off-by: simonsan <[email protected]>
aawsome
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-commands
Area: Related to commands in `rustic`
A-config
Area: Related to the config file functionality and format
C-refactor
Category: Refactoring of already existing code
S-waiting-for-review
Status: PRs waiting for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from #973