Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mount): rename fields for clarity, add user options for mount #1353

Merged
merged 18 commits into from
Nov 25, 2024

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented Nov 11, 2024

Addresses review feedback from #973

@simonsan simonsan added A-commands Area: Related to commands in `rustic` C-refactor Category: Refactoring of already existing code A-config Area: Related to the config file functionality and format labels Nov 11, 2024
@simonsan simonsan changed the title refactor(mount): rename fields for clarity refactor(mount): rename fields for clarity, add user options for mount Nov 12, 2024
@simonsan simonsan added the S-waiting-for-review Status: PRs waiting for review label Nov 12, 2024
src/commands/mount.rs Outdated Show resolved Hide resolved
src/commands/mount.rs Outdated Show resolved Hide resolved
src/commands/mount.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/commands/mount.rs Outdated Show resolved Hide resolved
src/commands/mount.rs Outdated Show resolved Hide resolved
src/commands/mount.rs Outdated Show resolved Hide resolved
Copy link
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aawsome aawsome added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 1bdb914 Nov 25, 2024
31 checks passed
@aawsome aawsome deleted the refactor/mount-cmd branch November 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-commands Area: Related to commands in `rustic` A-config Area: Related to the config file functionality and format C-refactor Category: Refactoring of already existing code S-waiting-for-review Status: PRs waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants